Closed GoogleCodeExporter closed 9 years ago
Already fixed in 1.25, see issue 191 :
http://code.google.com/p/get-flash-videos/issues/detail?id=191
Original comment by stav...@gmail.com
on 24 Dec 2010 at 5:30
argh... missed it... Sry ! Thx !
Original comment by jcden...@gmail.com
on 24 Dec 2010 at 5:43
Patch applied in GFV 1.24 , Still don't work.
Is it me only ?
Original comment by jcden...@gmail.com
on 26 Dec 2010 at 1:55
When I tried to apply the patch it failed for me too (using linux version).
Here's an updated patch that applies cleanly on 1.24 installed using the deb
package.
Apply with:
patch /usr/share/perl5/FlashVideo/Site/Tou.pm Tou.pm-patch
Pretty sure it won't work on Windows version. Might work on Mac OS X but you
might need to change the path of the Tou.pm file. I'm unaware of how they
"build" on Mac OS X.
Cheers!
Original comment by olivier....@gmail.com
on 31 Dec 2010 at 9:33
Attachments:
Thx Olivier,
This patch is the same proposed in issue 191 (if I'm not mistaken).
I tried it all under Ubuntu (1.24 + your patch) and it works fine.
Under OS 10.6, I found this :
- I tried to update GFV again but nothing.
- I get GFV via GIT and added the plugin. Did not worked (it adds the
file, I checked, but it is not called by the executable - possibly because
it is a combined one / default install proposed for OS X)
git clone git://github.com/monsieurvideo/get-flash-videos.git
./get_flash_videos --add-plugin
~/get-flash-videos/lib/FlashVideo/Site/Tou.pm
- This neither (result attached... https gives problem, normal ? "wget
--no-check-certificate" works fine, )
./get_flash_videos --add-plugin
https://github.com/monsieurvideo/get-flash-videos/raw/master/lib/FlashVideo/Site
/Tou.pm
In the end, I had to edit the executable and change it manually (simple way
for everyone)
sudo open -e ./get_flash_videos
Then search for "tou.pm" (Command+F), and then replace the six lines
according to the patch.
Save and close and this time it rocks.
Conclusions :
- Patch is working on OSX
- add-plugin works (except https),
- "./get_flash_videos" (combined version) doesn't read first in
"~/.get_flash_videos/plugins", it uses itself
I guess my issue is not related to the patch in the end.
Anyway, thx again.
Original comment by jcden...@gmail.com
on 1 Jan 2011 at 4:02
See also http://code.google.com/p/get-flash-videos/issues/detail?id=203
plugins do not override internal modules
The tou.pm patch was meant to be applied on the .pm source, not on the
released/built g-f-v.pl
Original comment by stav...@gmail.com
on 1 Jan 2011 at 4:57
@Stav : Thx!
Original comment by jcden...@gmail.com
on 24 Jan 2011 at 2:57
Thanks! it works a1! great job guys!
Original comment by julienma...@gmail.com
on 6 May 2011 at 2:20
Original comment by mjbauer95
on 17 May 2011 at 3:11
Original issue reported on code.google.com by
jcden...@gmail.com
on 24 Dec 2010 at 12:03