Suggestion: Adding bans in game lobby

[GoogleCodeExporter]

Sometimes I would like to ban people in the lobby for certain reasons such
as already being banned on XML lists or being assholes, etc. It would be
nice if you can simply do !addban NAME and simply add it instead of saying
MATCH NOT FOUND.

Thanks!

Original issue reported on code.google.com by luc...@live.com on 1 Nov 2008 at 10:44

[GoogleCodeExporter]

The !addban and !ban commands shouldn't work at all in the game lobby (they 
should
print nothing at all instead of "match not found"). I've restricted it to work 
this
way because the ingame !addban and !ban commands search through an internal list
which is populated when the game starts rather than the actual player list. 
This is
because  you usually want to ban players who leave the game but they are 
removed from
the player list when they leave!

I will have to duplicate the existing code and make it search the player list 
during
the lobby state and the other list the rest of the time.

Original comment by hogantp on 3 Nov 2008 at 1:01

• Changed state: Accepted
• Added labels: Type-Enhancement, Priority-Low
• Removed labels: Type-Defect, Priority-Medium

[GoogleCodeExporter]

Well, it is currently returning match not found. It would be nice so that I can 
ban
those who come into the lobby and start insulting or similar things like that.

Original comment by luc...@live.com on 3 Nov 2008 at 5:51

[GoogleCodeExporter]

I've just tested this myself and it's not printing anything when I use the 
!addban or
!ban commands in the lobby. Can you provide more information on what version 
you're
using and exactly how to reproduce this? Have you made any edits to the source 
code?

I realize it's sort of secondary to the original suggestion of being able to ban
people in the lobby but this behaviour is unexpected and I would like to sort 
it out
first.

Original comment by hogantp on 3 Nov 2008 at 6:42

[GoogleCodeExporter]

This is in the game lobby. If I type !addban test it returns "Unable to ban 
player
[test]. No matches found."

If I use this in my clan channel lobby, it does actually ban the user I 
specify. It
returns with "Banned user [test] on server [useast.battle.net].

Original comment by luc...@live.com on 3 Nov 2008 at 7:39

[GoogleCodeExporter]

By the way, I am using version 10.4 and I haven't modified the source code more 
than
for the GHost name and welcome message, nothing else.

Original comment by luc...@live.com on 3 Nov 2008 at 7:40

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

After few tests i realise that addban partialy works on gamelobby IF you 
whisper the
bot however it's like lucasgomez said  take a look :

http://beta.eurobattle.net/testforvarlock.jpg

However i made another test : 

I banned a friend using this same method (/w addban nick) inside the gamelobby 
and
kicked him;., When he tried to return to the game he couldnt the bot actualy 
banned him.

The ban works if you use whisper method (effect is the same as if you write on a
gameroom) but it does not if you send on chat level.

Original comment by amidamar...@gmail.com on 4 Nov 2008 at 11:38

[GoogleCodeExporter]

Thanks for the screenshot, it helped. It turns out there's another bug where 
commands
with aliases can be executed when they shouldn't be able to because of an 
ordering issue.

Original comment by hogantp on 4 Nov 2008 at 2:11

[GoogleCodeExporter]

So I found a bug and gained a suggestion! Nice! Looking forward to the 
fix/addon.

Original comment by luc...@live.com on 7 Nov 2008 at 5:14

[GoogleCodeExporter]

Original comment by hogantp on 10 Nov 2008 at 6:36

• Changed state: Started

[GoogleCodeExporter]

Done (r27).

Original comment by hogantp on 11 Nov 2008 at 4:56

• Changed state: Fixed