google-code-export / google-api-java-client

Automatically exported from code.google.com/p/google-api-java-client
1 stars 0 forks source link

rename Google API methods (e.g. delete) to createXXXRequest (e.g. createDeleteRequest) #698

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
External references, such as a standards document, or specification?

https://google-api-client-libraries.appspot.com/documentation/calendar/v3/java/l
atest/com/google/api/services/calendar/Calendar.Calendars.html#delete(java.lang.
String)

Java environments (e.g. Java 6, Android 2.3, App Engine, or All)?

All

Please describe the feature requested.

For example (borrowed from CalendarSample.java):

    client.calendars().delete(calendar.getId()).execute();

Some users complain that it is unintuitive that you have to call execute().  
When you first try the library you intuitively guess that calling delete() 
should actually delete the Calendar.  We can hopefully make it more intuitive 
by renaming it createDeleteRequest, e.g.:

    client.calendars().createDeleteRequest(calendar.getId()).execute();

Original issue reported on code.google.com by yan...@google.com on 3 Jan 2013 at 7:14

GoogleCodeExporter commented 9 years ago
Actually newDeleteRequest() sounds better to me than createDeleteRequest().  
That said, at this point changing the name of the method is too large of a 
change for existing users, so I think we have to Won't Fix it for that reason.

Original comment by yan...@google.com on 9 Jan 2013 at 8:22

GoogleCodeExporter commented 9 years ago

Original comment by yan...@google.com on 12 Jan 2013 at 4:23