google-code-export / google-checkout-java-sdk

Automatically exported from code.google.com/p/google-checkout-java-sdk
1 stars 0 forks source link

AbstractCheckoutRequest getDocumnet() should really be public #64

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Have you every tried to use CheckoutShoppingCart 
addMerchantPrivateDataNode(Element node)  ??

Because it is the burden of the caller to create an Element, it is only
practical to have access to the owning Document object. That is really what
you need if you use the mxl libs directly to create an Element.

Proposed fix:  in AbstractCheckoutRequest, change getDocument() to be
public rather than protected

  /**
   * @return The document for this CheckoutRequest
   */
  public Document getDocument() {
    return document;
  }

It doe not appear that the google-checkout-java-sdk has really been used,
otherwise some of these obvious things would have been caught. Nor does it
appear that any of the reported issues are being addressed.

Original issue reported on code.google.com by broc.s...@gmail.com on 9 Apr 2009 at 3:06

GoogleCodeExporter commented 9 years ago

Original comment by mihai.io...@gmail.com on 28 Mar 2011 at 11:27