Fixes for fedora core 9 to finish the compilation.

[GoogleCodeExporter]

js-1.70 provide by fedora officially had a bug that two header files was
missing:jskeyword.tbl and jsproto.tbl.

1, js package fix.

you can download the original fedora src.rpm for js.
http://archive.linux.duke.edu/pub/fedora/linux/releases/9/Everything/source/SRPM
S/js-1.70-2.fc9.src.rpm

and use the attached "js.spec" to compile it. then install the binary
packages of js.

2,Apply patch

after js-1.70 installed, please download google gadgets and apply the
google-gadgets-compile.patch below.

DO NOT foget run autoreconf  after patch applied.

this patch fix gekco detection and nspr header issue happend on mozilla.

We you applied this patch, just run ./configure --prefix=/usr.

3, Another choice for js package fix is:

download two .tbl files below and copy it to /usr/include/js directory.

Original issue reported on code.google.com by cjac...@gmail.com on 2 Jun 2008 at 2:24

Attachments:

• js.spec
• google-gadgets-compile.patch
• jskeyword.tbl
• jsproto.tbl

[GoogleCodeExporter]

Sorry, please copy these two .tbl files to /usr/include.
not /usr/include/js

Original comment by cjac...@gmail.com on 2 Jun 2008 at 2:38

[GoogleCodeExporter]

This fix works for the configure.  Have you/do you want to submit your js.spec 
file
to the Fedora group?  

I am getting a different compile error:
backoff.cc: In static member function 'static uint64_t
ggadget::Backoff::Impl::GetNextRequestInterval(int)':
backoff.cc:65: error: 'rand' was not declared in this scope
make[4]: *** [libggadget-1.0_la-backoff.lo] Error 1

but I am going to look through the documentation a bit and see if I am missing a
devel package.

Original comment by BigJoe1...@gmail.com on 2 Jun 2008 at 3:07

[GoogleCodeExporter]

backoff.cc, basic_element.cc need #include <cstdlib> because Fedora 9 uses gcc 
4.3.

Now I am working on this error:
cc1plus: warnings being treated as errors
contentarea_element.cc: In member function 'void
ggadget::ContentAreaElement::Impl::Draw(ggadget::CanvasInterface*)':
contentarea_element.cc:271: error: conversion to 'int' from 'size_t' may alter 
its value
contentarea_element.cc: In member function 'void
ggadget::ContentAreaElement::Impl::ScriptSetContentItems(ggadget::ScriptableInte
rface*)':
contentarea_element.cc:350: error: conversion to 'int' from 'size_t' may alter 
its value
contentarea_element.cc: In member function 'bool
ggadget::ContentAreaElement::Impl::AddContentItem(ggadget::ContentItem*,
ggadget::ContentAreaElement::DisplayOptions)':
contentarea_element.cc:427: error: no matching function for call to
'find(__gnu_cxx::__normal_iterator<ggadget::ContentItem**,
std::vector<ggadget::ContentItem*, std::allocator<ggadget::ContentItem*> > >,
__gnu_cxx::__normal_iterator<ggadget::ContentItem**,
std::vector<ggadget::ContentItem*, std::allocator<ggadget::ContentItem*> > >,
ggadget::ContentItem*&)'
contentarea_element.cc: In member function 'bool
ggadget::ContentAreaElement::Impl::RemoveContentItem(ggadget::ContentItem*)':
contentarea_element.cc:468: error: no matching function for call to
'find(__gnu_cxx::__normal_iterator<ggadget::ContentItem**,
std::vector<ggadget::ContentItem*, std::allocator<ggadget::ContentItem*> > >,
__gnu_cxx::__normal_iterator<ggadget::ContentItem**,
std::vector<ggadget::ContentItem*, std::allocator<ggadget::ContentItem*> > >,
ggadget::ContentItem*&)'
make[2]: *** [libggadget-1.0_la-contentarea_element.lo] Error 1
make[2]: Leaving directory
`/home/harnisjl/Download/google-gadgets-for-linux-0.9.1/ggadget'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/home/harnisjl/Download/google-gadgets-for-linux-0.9.1/ggadget'
make: *** [all] Error 2

Original comment by BigJoe1...@gmail.com on 2 Jun 2008 at 5:06

[GoogleCodeExporter]

This looks like it is all fixed in SVN.  I pulled svn down and everything build
(after applying the js rpms built from the .spec file attached to this ticket.

Original comment by BigJoe1...@gmail.com on 2 Jun 2008 at 5:32

[GoogleCodeExporter]

Great, please help to submit the js fix to fedora.
It is a bug of Fedora, they need fix it.

Original comment by cjac...@gmail.com on 3 Jun 2008 at 1:50

[GoogleCodeExporter]

Upstreamed the issue: https://bugzilla.redhat.com/show_bug.cgi?id=449715

Original comment by BigJoe1...@gmail.com on 3 Jun 2008 at 2:52

[GoogleCodeExporter]

It looks like this fix has been pushed to Rawhide (Fedora's development 
branch).  I
am hoping to see it roll through testing over the next week or so.

Original comment by BigJoe1...@gmail.com on 5 Jun 2008 at 1:41

[GoogleCodeExporter]

Original comment by james...@gmail.com on 8 Jun 2008 at 5:29

• Changed state: Fixed