failed to build into Ubuntu 8.04

[GoogleCodeExporter]

What steps will reproduce the problem?
1. download and untar latest
2. configure
3. make

What is the expected output? 
make done

What do you see instead?
/bin/bash ../../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.
-I../..  -D__STDC_CONSTANT_MACROS                -DNDEBUG               
-DGGL_MODULE_DIR=\"/usr/local/lib/google-gadgets/modules\"                
  -DGGL_INCLUDE_DIR=\"/usr/local/include/google-gadgets\"                
-DGGL_SYSDEPS_INCLUDE_DIR=\"/usr/local/lib/google-gadgets/include\"       
          -DGGL_LIBEXEC_DIR=\"/usr/local/lib/google-gadgets\"            
-DGGL_RESOURCE_DIR=\"/usr/local/share/google-gadgets\" -DGGL_HOST_LINUX=1
-DHAVE_X11=1                 -DMOZILLA_FIVE_HOME=\"/usr/lib/xulrunner\"
-DHAVE_PTHREAD=1 -DSYS_UNIX -DHAVE_STDLIB -DUNIQUE_HISTORY -DUSE_DIRENT
-DHIDE -DHAVE_TCGETATTR -DANSI_ARROWS  -O2 -Werror -Wall -Wconversion
-Wno-implicit -Wno-pointer-sign -Wno-conversion -O3 -march=i686 -pipe -MT
libeditline_la-editline.lo -MD -MP -MF .deps/libeditline_la-editline.Tpo -c
-o libeditline_la-editline.lo `test -f 'editline.c' || echo './'`editline.c
 gcc -DHAVE_CONFIG_H -I. -I../.. -D__STDC_CONSTANT_MACROS -DNDEBUG
-DGGL_MODULE_DIR=\"/usr/local/lib/google-gadgets/modules\"
-DGGL_INCLUDE_DIR=\"/usr/local/include/google-gadgets\"
-DGGL_SYSDEPS_INCLUDE_DIR=\"/usr/local/lib/google-gadgets/include\"
-DGGL_LIBEXEC_DIR=\"/usr/local/lib/google-gadgets\"
-DGGL_RESOURCE_DIR=\"/usr/local/share/google-gadgets\" -DGGL_HOST_LINUX=1
-DHAVE_X11=1 -DMOZILLA_FIVE_HOME=\"/usr/lib/xulrunner\" -DHAVE_PTHREAD=1
-DSYS_UNIX -DHAVE_STDLIB -DUNIQUE_HISTORY -DUSE_DIRENT -DHIDE
-DHAVE_TCGETATTR -DANSI_ARROWS -O2 -Werror -Wall -Wconversion -Wno-implicit
-Wno-pointer-sign -Wno-conversion -O3 -march=i686 -pipe -MT
libeditline_la-editline.lo -MD -MP -MF .deps/libeditline_la-editline.Tpo -c
editline.c  -fPIC -DPIC -o .libs/libeditline_la-editline.o
cc1: warnings being treated as errors
editline.c: In function 'h_last':
editline.c:314: warning: passing argument 1 of 'TTYputs' discards
qualifiers from pointer target type
make: *** [libeditline_la-editline.lo] Error 1

What version of the product are you using? On what operating system?
google-gadgets-for-linux-0.9.1
Ubuntu Hardy Heron 8.04
Linux cappelletti 2.6.22-14-generic #1 SMP Sun Oct 14 23:05:12 GMT 2007
i686 GNU/Linux

Original issue reported on code.google.com by luca.cap...@gmail.com on 4 Jun 2008 at 1:32

[GoogleCodeExporter]

I built it just fine in Hardy. Though when I configured I made sure all the 
options
displayed at the end showed yes...which means I probably installed a lot more 
dev
files than necessary. Also, I did not configure with the debug option.

Original comment by bped...@gmail.com on 4 Jun 2008 at 4:43

[GoogleCodeExporter]

would be nice to specify which dev files are necessary, or at least which ones 
were
installed which allowed the host to be installed

Original comment by williams...@gmail.com on 4 Jun 2008 at 9:04

[GoogleCodeExporter]

Well, I can't remember exactly what packages were installed but I have the dpkg 
log
of all the stuff...so I separated out all the stuff around the time I compiled 
ggl
and attached is a list of all the packages that dpkg lists as installed during 
that time

Original comment by bped...@gmail.com on 4 Jun 2008 at 9:22

Attachments:

• packages.txt

[GoogleCodeExporter]

Here is the command I used to install the development packages needed to 
compile with
*all* options under Ubuntu 8.04:

apt-get install libxml2-dev libcurl4-openssl-dev libgstreamer0.10-dev 
libgtk2.0-dev
libqt4-dev libqtwebkit-dev libmozjs-dev libdbus-dev libdbus-1-dev libxul-dev
libgstreamer-plugins-base0.10-dev librsvg2-dev

Original comment by jc...@anteil.com on 5 Jun 2008 at 12:57

[GoogleCodeExporter]

root@cappelletti:/# apt-get update
....

root@cappelletti:/# apt-get upgrade
Reading package lists... Done
Building dependency tree       
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

root@cappelletti:/# apt-get install libxml2-dev libcurl4-openssl-dev
libgstreamer0.10-dev libgtk2.0-dev libqt4-dev libqtwebkit-dev libmozjs-dev
libdbus-dev libdbus-1-dev libxul-dev libgstreamer-plugins-base0.10-dev 
librsvg2-dev
Reading package lists... Done
Building dependency tree       
Reading state information... Done
libxml2-dev is already the newest version.
libcurl4-openssl-dev is already the newest version.
libgstreamer0.10-dev is already the newest version.
libgtk2.0-dev is already the newest version.
libmozjs-dev is already the newest version.
libmozjs-dev set to manually installed.
E: Couldn't find package libdbus-dev
root@cappelletti:/#

Original comment by luca.cap...@gmail.com on 5 Jun 2008 at 7:53

[GoogleCodeExporter]

hardy@cappelletti:~/GOOGLE/GADGETS$ tar -xf 
google-gadgets-for-linux-0.9.1.tar.gz 
hardy@cappelletti:~/GOOGLE/GADGETS$ cd google-gadgets-for-linux-0.9.1/
hardy@cappelletti:~/GOOGLE/GADGETS/google-gadgets-for-linux-0.9.1$ ./configure
--disable-xmltest --disable-qt-system-framework 
--disable-qtwebkit-browser-element
--disable-libggadget-qt --disable-qt-host

...
Output in the attached file
...
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands

Build options:
  Version                       0.9.1
  Install prefix                /usr/local
  Install included libltdl      no
  Build shared libs             yes
  Build static libs             yes
  Enable debug                  no
  Host type                     linux

 Libraries:
  GTK SVG Support               yes
  Build libggadget-gtk          yes
  Build libggadget-qt           no
  Build libggadget-dbus         yes

 Extensions:
  Build dbus-script-class       yes
  Build gtk-edit-element        yes
  Build gtkmoz-browser-element  yes
  Build qtwebkit-browser        no
  Build gst-audio-framework     yes
  Build gst-mediaplayer-element yes
  Build gtk-system-framework    yes
  Build qt-system-framework     no
  Build linux-system-framework  yes
  Build smjs-script-runtime     yes
  Build curl-xml-http-request   yes
  Build qt-xml-http-request     no
  Build libxml2-xml-parser      yes

 Hosts:
  Build gtk host                yes
  Build qt host                 no

hardy@cappelletti:~/GOOGLE/GADGETS/google-gadgets-for-linux-0.9.1$ make

...
Output in the attached file
...

editline.c: In function 'h_last':
editline.c:314: warning: passing argument 1 of 'TTYputs' discards qualifiers 
from
pointer target type
make[3]: *** [libeditline_la-editline.lo] Error 1
make[3]: Leaving directory
`/home/hardy/GOOGLE/GADGETS/google-gadgets-for-linux-0.9.1/third_party/editline'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/home/hardy/GOOGLE/GADGETS/google-gadgets-for-linux-0.9.1/third_party'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory 
`/home/hardy/GOOGLE/GADGETS/google-gadgets-for-linux-0.9.1'
make: *** [all] Error 2
hardy@cappelletti:~/GOOGLE/GADGETS/google-gadgets-for-linux-0.9.1$

Seems a problem related in line 314 of file editline.c in "third_party" folder

Original comment by luca.cap...@gmail.com on 5 Jun 2008 at 8:02

Attachments:

• make_ErrorOutput.txt

[GoogleCodeExporter]

Hello, I found the problem:
-O3 CFLAGS optimization does not work.
Changed to -Os and compile well.
Probably wirks well with standard -O2 but I'm trying now to retain space and 
let the
first startup engine speed up.

Original comment by luca.cap...@gmail.com on 5 Jun 2008 at 9:21

[GoogleCodeExporter]

see also bug 109 should be fixed in 0.9.2 as I didn't get the error AND there 
is a
way to disable the -Werror.

Original comment by hfigui...@gmail.com on 7 Jun 2008 at 5:36

[GoogleCodeExporter]

ok I think this issue should retain CLOSED I'll report against 0.9.2 thank a 
lot :)

Original comment by luca.cap...@gmail.com on 7 Jun 2008 at 10:19

[GoogleCodeExporter]

Original comment by james...@gmail.com on 8 Jun 2008 at 6:16

• Changed state: Fixed