Stage.PRODUCTION doesn't load @Singletons eagerly

[GoogleCodeExporter]

That is, given...

  void testAnnotatedSingletonEagerlyLoads() {
    Guice.createInjector(Stage.PRODUCTION, new AbstractModule() {
      protected void configure() {
        bind(Hoo.class).to(Har.class);
      }
    });
    assertEquals(1, Har.count);
  }

  static interface Hoo {}
  @Singleton
  static class Har implements Hoo {
    static int count = 0;
    public Har() {
      count++;
    }
  }

.... fails.  (Har.count == 0)

Original issue reported on code.google.com by sberlin on 15 May 2008 at 2:00

[GoogleCodeExporter]

The attached patch fixes the bug (and adds this test into PreloadingTest).  The 
premise is that eager-loaders are stored only if an explicit "asEagerSingleton" 
request is made on the command.  Those kinds of loaders are always run.  Then, 
if 
the stage is production, all bindings are iterated through and if the scope of 
the 
binding (or in the case of a linked binding with no explicit scope, the scope 
of its 
target binding) is singleton, the binding is also loaded.

It was a little more complicated than just changing LinkedBindingImpl because 
of all 
creationListeners had to be run before getScope() could be called, otherwise 
the 
target binding wouldn't have been created yet, which led into very weird JIT 
binding 
creations. 

Original comment by sberlin on 15 May 2008 at 2:57

Attachments:

• annotation-eagerly-load.txt

[GoogleCodeExporter]

Fixed. I really liked your approach, so I took it one step further. 

Please code review rev 498 to see if it does what you want:
http://code.google.com/p/google-guice/source/detail?r=498

Original comment by limpbizkit on 2 Jun 2008 at 7:03

• Changed state: Fixed

[GoogleCodeExporter]

A consequence of the fix is that Guice now eagerly loads all just-in-time 
@Singletons. We probably should have 
been doing this before.

Original comment by limpbizkit on 2 Jun 2008 at 4:45