google-code-export / google-guice

Automatically exported from code.google.com/p/google-guice
Apache License 2.0
2 stars 1 forks source link

Provide JarJar-less builds in official releases #289

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
There has been a long history of problems using JarJar-processed files. I
suggest you offer two kinds JAR files in official builds:

module-all.jar includes dependencies
module.jar excludes dependencies

This is a well established paradigm used by many other open-source
projects. In fact, I would go a step further and suggest that you simply
offer guice-all.jar for JarJar users (includes all plugins) and separate
JAR files for non-JarJar users.

This should be extremely easy to implement and users would actually see a
size decrease relative to the current builds (which uses JarJar separately
per plugin which is expensive).

Original issue reported on code.google.com by gili.tza...@gmail.com on 25 Dec 2008 at 5:55

GoogleCodeExporter commented 9 years ago
the "long history of problems" has mainly been from people working off trunk. 
afaik jarjar has never 
caused issues in the guice 1.0 release. i really dont think we should be 
exposing guice internals to users, 
that's inviting trouble. 

in any case it is trivial to build your own distro without jarjar rather than 
asking us to support two 
different binary paradigms. 

Original comment by dha...@gmail.com on 26 Dec 2008 at 2:27

GoogleCodeExporter commented 9 years ago
I don't want to have to support all possible versions of cglib and Google 
collections. Jarjar allows us to control 
which versions our users get.

Original comment by limpbizkit on 27 Dec 2008 at 11:40

GoogleCodeExporter commented 9 years ago
Dhanji, Could you at least support the Ant build target even if you won't ship 
it for
external distribution?

Jesse, I'm not asking you to support all possible versions of cglib and 
collections,
just the one Guice is built against. Users can always drop in their own 
versions and
rebuild, so long as there is an Ant target for this.

Original comment by gili.tza...@gmail.com on 28 Dec 2008 at 1:29