ConstantBindingBuilder should take Object

[GoogleCodeExporter]

Allow ConstantBindingBuilder to accept a Object, and use it's class as
type. Patch attached.

Original issue reported on code.google.com by mathias....@gmail.com on 6 Feb 2009 at 7:03

[GoogleCodeExporter]

Patch.

Original comment by mathias....@gmail.com on 6 Feb 2009 at 7:04

Attachments:

• constantbindingbuilder.patch

[GoogleCodeExporter]

Just use bind(...).annotatedWith(...).toInstance() which is much more explicit 
about the type being bound. With 
getClass(), there's a lot of problems since the runtime class may not be 
significant (such as anonymous inner 
classes, etc.)

Original comment by limpbizkit on 7 Feb 2009 at 1:31

• Changed state: WontFix

[GoogleCodeExporter]

And then what in the case where you don't know the value class? Imagine this:

for (Map.Entry<String, Object> param :
action.getDefinition().getParamDefaultsMap().entrySet()) {

bind(param.getValue().getClass()).annotatedWith(Names.named(param.getKey())).toI
nstance(param.getValue());
}

Original comment by mathias....@gmail.com on 7 Feb 2009 at 1:33

[GoogleCodeExporter]

your example using plain bind() statements is sufficient. We don't really want 
to encourage folks to write 
bindings that they don't know statically.

Original comment by limpbizkit on 7 Feb 2009 at 5:01