search

google-code-export / google-guice

Automatically exported from code.google.com/p/google-guice
Apache License 2.0
2 stars 1 forks source link

No source jars in maven repository #382

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The newly uploaded guice 1.0 artifacts don't have any source jars attached.  
These make it much 
easier to work with libraries like guice in an IDE, as plugins like m2eclipse 
will automatically 
download the source.  Would it be possible to upload the source jars?

Original issue reported on code.google.com by dom.happ...@gmail.com on 6 Jun 2009 at 7:16

GoogleCodeExporter commented 9 years ago 
Greg, you're our Maven guy. I'm glad we have a Maven guy!

Original comment by limpbizkit on 22 Jun 2009 at 2:24

GoogleCodeExporter commented 9 years ago 
I've just been looking at the ant build (on the 2.0-maven branch).  This builds 
the correct source jars already 
(since r467).  However, in order to make things maven-happy, they need to be 
called *-sources.jar instead of 
*-src.jar.  Apart from that, they should be ready to upload to a maven 
repository.

diff --git a/common.xml b/common.xml
index e14901e..1e20bb0 100644
--- a/common.xml
+++ b/common.xml
@@ -96,7 +96,7 @@
   <target name="source.jar"
       description="Create a .jar file with sources">
     <mkdir dir="${build.dir}"/>
-    <zip destfile="${build.dir}/${ant.project.name}-${version}-src.jar">
+    <zip destfile="${build.dir}/${ant.project.name}-${version}-sources.jar">
       <fileset dir="src"/>
     </zip>
   </target>

Original comment by dom.happ...@gmail.com on 23 Jun 2009 at 7:13

GoogleCodeExporter commented 9 years ago 
Doh.  That's for the 2.0 branch, not the 1.0 branch.  That said, back-porting 
r467 to 1.0 along with that patch 
should produce the expected results.

Original comment by dom.happ...@gmail.com on 23 Jun 2009 at 7:14

GoogleCodeExporter commented 9 years ago 
There still is no -sources.jar in http://google-maven-
repository.googlecode.com/svn/repository/com/google/inject/guice/2.0/ nor in 
http://google-maven-
repository.googlecode.com/svn/repository/com/google/inject/guice/1.0/

Original comment by esko.luo...@gmail.com on 17 Aug 2009 at 7:38

GoogleCodeExporter commented 9 years ago 
Can anyone place the sources in maven repo for 2.0, pretty please with sugar on 
top?

Original comment by dominik....@gmail.com on 18 Nov 2009 at 11:16

GoogleCodeExporter commented 9 years ago 
 Sources please. :-)

Original comment by james.r...@gmail.com on 21 Dec 2009 at 9:02

GoogleCodeExporter commented 9 years ago 
Can any one please update us on the status of this task?

Original comment by jigar.go...@gmail.com on 18 Mar 2010 at 9:36

GoogleCodeExporter commented 9 years ago 
I've taken the liberty to create a sources jar. Simply place this in your local 
repo and all should work, 
~/.m2/repository/com/google/inject/guice/2.0.

Original comment by james.r...@gmail.com on 25 Mar 2010 at 2:57

Attachments:

GoogleCodeExporter commented 9 years ago 
Still no sources in Maven, eh?

Original comment by stephenson.james on 20 Aug 2010 at 3:21

GoogleCodeExporter commented 9 years ago 
Also remember to add the sources for all extensions, such as multibindings. And 
put them to the Maven Central repository, not only google-maven-
repository.googlecode.com

Original comment by esko.luo...@gmail.com on 25 Aug 2010 at 4:16

GoogleCodeExporter commented 9 years ago 
I would also like to see source (and JavaDoc) JARs for Guice 2.0, please.

Original comment by steven.b...@gmail.com on 21 Nov 2010 at 9:44

GoogleCodeExporter commented 9 years ago 
This is fixed for Guice 3.0+.

Original comment by sberlin on 20 Feb 2011 at 12:28

GoogleCodeExporter commented 9 years ago 
anything for guice 2.0 backports? thanks for the sources-jar but would be nice 
to have it in mvn repo too!

Original comment by LeetCh...@gmail.com on 18 Aug 2013 at 8:28