google-code-export / gwt-ext

Automatically exported from code.google.com/p/gwt-ext
0 stars 0 forks source link

LayoutRegionListener does not implement 'beforeremove' with the intended effect. #72

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a normal borderLayout.
2. Add a LayoutRegionListener to one of the regions.
   - the listener shall implement the onBeforeRemove(...) and
     return a value. Any will do, true or false doesn't do anything
     different.
3. Add one or more closeable content panels to that region.
4. Close the content panel.
5. The onBeforeRemove(...) method will execute but regardless of the return
value the panel is still closed.

What is the expected output? What do you see instead?

  The content panel should not be closed. The content panel was closed.

What version of the product are you using? On what operating system?

  GWT-Ext 0.91, Win XP

Please provide any additional information below.

  The error is due to the implementation on row 232 of
addLayoutRegionListener in the LayoutRegion class. The function should not
return a value, instead it should set "e.cancel = true" if onBeforeRemove()
returns false.

Original issue reported on code.google.com by intern...@gmail.com on 21 Aug 2007 at 3:20

GoogleCodeExporter commented 9 years ago

Original comment by sanjiv.j...@gmail.com on 21 Aug 2007 at 11:28