google-code-export / gwt-ext

Automatically exported from code.google.com/p/gwt-ext
0 stars 0 forks source link

New class for Ext.ux.Accordion Widget #97

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This is not a base widget for Ext Js.

Here is the link:
http://aariadne.com/accordion-preview/

Original issue reported on code.google.com by or...@newmail.ru on 5 Sep 2007 at 3:37

GoogleCodeExporter commented 9 years ago

Original comment by sanjiv.j...@gmail.com on 7 Sep 2007 at 2:28

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Hi. I've been doing the same, trying to develop this widget for gwt-ext. I've 
develop
both config classes. You extend BaseConfig class in both classes, why?? I've 
extend
from ContentPanelConfig. I've develop wrappers for Accordion and InfoPanel. It 
works
but not at all. I can't undock InfoPanels, animation does not work, and when 
you open
a panel, previous opened one is not closed. Please, if you can help me maybe we 
can
add both classes to gwt-ext project.

Regards.

Original comment by mangrar on 10 Sep 2007 at 3:38

Attachments:

GoogleCodeExporter commented 9 years ago
I know that it is much better to extend ContentPanelConfig.
I can't remeber now what was wrong with it.

Ok Let's try to do it.

Original comment by or...@newmail.ru on 10 Sep 2007 at 4:26

GoogleCodeExporter commented 9 years ago
Let us choose names for classes.

Which one is the best for you?
AccordionPanel
AccordionPanelConfig
- or -
Accordion
AccordionConfig

Original comment by or...@newmail.ru on 10 Sep 2007 at 4:32

GoogleCodeExporter commented 9 years ago
Here is the method add for Accordion:

    public void add(InfoPanel infoPanel) {
        add(jsObj, infoPanel.getJsObj());
    }

    private static native void add(JavaScriptObject accordion, JavaScriptObject
panel) /*-{
        accordion.add(panel);
    }-*/;

Original comment by or...@newmail.ru on 10 Sep 2007 at 4:36

GoogleCodeExporter commented 9 years ago
I've just tested my code
It can undock
It can animate.
And this one works either:
>> and when you open
>> a panel, previous opened one is not closed. 

Original comment by or...@newmail.ru on 10 Sep 2007 at 4:43

GoogleCodeExporter commented 9 years ago
I think the name you've choosen is better, AccordionPanelConfig instead of
AccordionConfig. Any idea about why undock and animation doesn't work??

Original comment by mangrar on 10 Sep 2007 at 7:48

GoogleCodeExporter commented 9 years ago
I suppose you didn't add panel to accordion. That is why it didn't work.

Original comment by or...@newmail.ru on 10 Sep 2007 at 8:00

GoogleCodeExporter commented 9 years ago
I've added 4 InfoPanels to accordion but any ca be undocked. Please, con you 
paste
your code??

Original comment by mangrar on 10 Sep 2007 at 9:14

GoogleCodeExporter commented 9 years ago
Here it is.

Original comment by or...@newmail.ru on 11 Sep 2007 at 6:18

Attachments:

GoogleCodeExporter commented 9 years ago
I have just arrived at work and I've pasted your add(InfoPanel) method. The 
Accordion
works very well, animation, undocking... Thanks. 

I'm thinking about contributing to the project. Now I'm adding comments to the
source. I need your email and name to add you to @author javadoc tag. If you 
want,
you can add this data yourself.

Original comment by mangrar on 11 Sep 2007 at 6:46

GoogleCodeExporter commented 9 years ago
Hi. I've added some javadoc to the classes and included all of them into the 
package
com.gwtext.client.widgets.layout. If you want, you can add your personal data 
into
@author tag in the AccordionPanel class.

Kind regards.

Original comment by mangrar on 11 Sep 2007 at 7:46

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks a lot. I don't want to add my personal data.

I remeber why I don't extend ContentPanelConfig.
Because there are some properties that doesn't work with InfoPanel for example
setClosable(boolean). And I suppose there are some more.
For me I don't like when objects have got not working properties.

Let us take ext.ux.zip as base code for our solution.

Original comment by or...@newmail.ru on 11 Sep 2007 at 8:57

GoogleCodeExporter commented 9 years ago
Ok, take it. Thanks a lot.

Original comment by mangrar on 11 Sep 2007 at 9:07

GoogleCodeExporter commented 9 years ago
One more thing. Please, in all file's headers, change my mail account by this:

invocationtargetexception@gmail.com

The other, is my personal one.

Thanks.

Original comment by mangrar on 11 Sep 2007 at 9:10

GoogleCodeExporter commented 9 years ago
I've discovered a bug. I've added 4 InfoPanel to the accordion. The first one 
has
collapsed property set to false, so, in the first load this InfoPanel is opened 
by
default. If you open another InfoPanel, the first panel isn't closed. Try it if 
you can.

Original comment by mangrar on 11 Sep 2007 at 9:26

GoogleCodeExporter commented 9 years ago
I don't have free time now. Maybe letter I'll try.
First of all try this thing with native Javascript. I suppose that this bug is 
in
Accordion.js

Original comment by or...@newmail.ru on 11 Sep 2007 at 11:37

GoogleCodeExporter commented 9 years ago
Ok. Thanks.

Original comment by mangrar on 11 Sep 2007 at 2:21

GoogleCodeExporter commented 9 years ago
Any plans when this will be integrated into the gwt ext release?

Original comment by sriprasa...@gmail.com on 3 Feb 2008 at 3:33

GoogleCodeExporter commented 9 years ago
Accordion is part of core Ext 2.0 and has been added to GWT-Ext 2.0.

See http://www.gwt-ext.com/dev/#accordionLayout

Original comment by sanjiv.j...@gmail.com on 6 Feb 2008 at 10:01