search

google-code-export / gwt-links

Automatically exported from code.google.com/p/gwt-links
2 stars 0 forks source link

make function shape a decoration shape #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I made be offbase on this, but there are some common methods in DecorationShape 
and FunctionShape.  Patch makes FunctionShape extend DecorationShape with 
common methods in DecorationShape

Original issue reported on code.google.com by david.du...@gmail.com on 13 May 2011 at 8:23

Attachments:

GoogleCodeExporter commented 9 years ago 
removed nonsense from patch

Original comment by david.du...@gmail.com on 13 May 2011 at 8:25

Attachments:

GoogleCodeExporter commented 9 years ago 
Don't you think a AbstractShape extended by FunctionShape and DecorationShape 
should be better?
Because, logically, FunctionShape doesn't inherit from DecorationShape.

Original comment by pierre.r...@gmail.com on 13 May 2011 at 8:51

GoogleCodeExporter commented 9 years ago 
That's what I started with, then I noticed that DecorationShape would be empty. 
 Totally up to you of course, I don't know quite enough just yet.  I'm really 
just tinkering... hope to add something meaningful eventually.

Original comment by david.du...@gmail.com on 13 May 2011 at 8:53

GoogleCodeExporter commented 9 years ago 
You've right, DecorationShape is now empty. But I'll do your refactoring idea 
by creating an abstract class. No matter if DecorationShape is empty. I think 
some methods will be added.

Thank you to notice this refactoring and hope you will continue to contribute ;)

Original comment by pierre.r...@gmail.com on 14 May 2011 at 6:34