google-code-export / gwt-log

Automatically exported from code.google.com/p/gwt-log
1 stars 0 forks source link

LogRecord reference to client.GWT.isClient breaks on server side with GWT 2.5 #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Server side issue with GWT 2.5RC1.

Servlet filter throws.
java.lang.NoClassDefFoundError: com/google/gwt/core/client/GWTBridge
    at com.allen_sauer.gwt.log.shared.LogRecord.<clinit>(LogRecord.java:34)
    at com.allen_sauer.gwt.log.client.Log.info(Log.java:216)
    at com.allen_sauer.gwt.log.client.Log.info(Log.java:196)

Per this patch it appears the reference should be to shared.GWT.isClient
http://gwt-code-reviews.appspot.com/1722803

Original issue reported on code.google.com by brian.to...@gmail.com on 2 Jul 2012 at 5:33

GoogleCodeExporter commented 9 years ago
Confirmed that changing the import to com.google.gwt.core.shared.GWT seems to 
take care of things.  Kind of a trivial change.  Do you want a patch?

Original comment by brian.to...@gmail.com on 2 Jul 2012 at 10:01

GoogleCodeExporter commented 9 years ago
Workarround: add the GWTBridge file to your Project. The GWT2.5-rc1 Version 
just extends from the shared-Version:

package com.google.gwt.core.client;
public abstract class GWTBridge extends com.google.gwt.core.shared.GWTBridge {
}

Original comment by KillerJo...@gmail.com on 30 Jul 2012 at 11:29

GoogleCodeExporter commented 9 years ago
I added a dummy GWTBridge file to my Project, but it seems hackish - a new 
build would be nice. :)

Original comment by Derek.Al...@gmail.com on 10 Oct 2012 at 6:52

GoogleCodeExporter commented 9 years ago
You should go ahead and make the change I mention above and do your own build.  
Its easy and has been working for me since July.  Now on 2.5RC2

Original comment by brian.to...@gmail.com on 10 Oct 2012 at 7:09

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Can a new version be released with this fixed?  Considering this stops gwt-log 
from being used with GWT 2.5 and is a 10 second fix

Original comment by tomfr...@gmail.com on 25 Jan 2013 at 4:16

GoogleCodeExporter commented 9 years ago
I am using GWT 2.5.  I added a dummy GWTBridge file to my Project, which seemed 
hackish, but works and I didn't want to have to compile my own version of GWT 
log...

Original comment by Derek.Al...@gmail.com on 25 Jan 2013 at 5:54

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Adding a dummy GWTBridge file, or fixing the import and compiling your own both 
work but are very hackish and not a great idea long term, especially as this is 
so easy for the author to fix

See patch: http://code.google.com/p/gwt-log/issues/detail?id=74

Original comment by tomfr...@gmail.com on 29 Jan 2013 at 9:12

GoogleCodeExporter commented 9 years ago
Issue 74 has been merged into this issue.

Original comment by fredsa on 29 Jan 2013 at 5:40

GoogleCodeExporter commented 9 years ago
Thank you for the bug report and patch.

This has been fixed in gwt-log-3.2.1

https://code.google.com/p/gwt-log/downloads/list

Original comment by fredsa on 29 Jan 2013 at 5:58