GoogleCodeExporter
commented
9 years ago OK, I'm attaching a patch for the issue - it can be applied to the test cased
posted with the issue to make it work.
The problem
===========
The problem is as follows. When binding a handler (via bindHandler in
HandlerModule) a bean is registered for each pair of Handler-Action. The class
of these beans is `ActionHandlerValidatorMapImpl`. By default spring gives a
bean an id equal to its class name, so having more than one Handler-Action pair
results in a collision of the generated id. When the spring context is run from
a web app the SpringUtils class takes care of changing the bean name:
public static <B> void registerBean(ApplicationContext applicationContext,
B instance) throws BeansException {
if (applicationContext instanceof GenericApplicationContext) {
(...)
} else if (applicationContext instanceof AbstractRefreshableWebApplicationContext) {
ConfigurableListableBeanFactory beanFactory = ((AbstractRefreshableWebApplicationContext) applicationContext).getBeanFactory();
beanFactory.registerSingleton(*generateName(beanFactory, createBeanDefinition(instance))*, instance);
}
}
private static String generateName(ConfigurableListableBeanFactory registry,
RootBeanDefinition definition) {
(...)
String id = generatedBeanName;
// Top-level bean: use plain class name.
// Increase counter until the id is unique.
int counter = -1;
while (counter == -1 || (registry.containsSingleton(id))) {
counter++;
id = generatedBeanName + "#" + counter;
}
return id;
}
Unfortunately, this does not apply to GenericApplicationContext.
A solution
==========
A solution is to add a counter value to both beans registered in
`GenericApplicationContext` and `AbstractRefreshableWebApplicationContext`.
I've created a class for this very reason:
public enum GwtpBeanNameGenerator {
INSTANCE;
private static AtomicInteger counter = new AtomicInteger(0);
public String generateBeanName(BeanDefinition definition,
BeanFactory factory) {
String generatedBeanName = definition.getBeanClassName();
if (generatedBeanName == null) {
if (definition.getParentName() != null) {
generatedBeanName = definition.getParentName() + "$child";
} else if (definition.getFactoryBeanName() != null) {
generatedBeanName = definition.getFactoryBeanName()
+ "$created";
}
}
if (!StringUtils.hasText(generatedBeanName)) {
throw new BeanDefinitionStoreException(
"Unnamed bean definition specifies neither "
+ "'class' nor 'parent' nor 'factory-bean' - can't generate bean name");
}
return generatedBeanName + "#" + counter.getAndIncrement();
}
}
It can be used as follows (in SpringUtils):
public static <B> void registerBean(ApplicationContext applicationContext,
B instance) throws BeansException {
if (applicationContext instanceof GenericApplicationContext) {
DefaultListableBeanFactory beanFactory = ((GenericApplicationContext) applicationContext)
.getDefaultListableBeanFactory();
beanFactory.registerSingleton(GwtpBeanNameGenerator.INSTANCE
.generateBeanName(createBeanDefinition(instance),
beanFactory), instance);
} else if (applicationContext instanceof AbstractRefreshableWebApplicationContext) {
ConfigurableListableBeanFactory beanFactory = ((AbstractRefreshableWebApplicationContext) applicationContext)
.getBeanFactory();
beanFactory.registerSingleton(GwtpBeanNameGenerator.INSTANCE
.generateBeanName(createBeanDefinition(instance),
beanFactory), instance);
}
}
For convenience I'm attaching both classes as well. I've tested in unit tests
and my two apps and it seems to work.
Hope it can help someone,
Igor Kupczynki
Original comment by puszczyk on 11 May 2012 at 4:15
Attachments:
Original issue reported on code.google.com by
puszczykon 11 May 2012 at 9:29Attachments: