search

google-code-export / gwt-test-utils

Automatically exported from code.google.com/p/gwt-test-utils
1 stars 0 forks source link

PlaceHistoryMapperCreateHandler doesn't provide an unique prefix #132

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The bigger problem is that any test that goes there -- i.e. 
GWT.create(MyPlaceHistoryMapper.class) -- will never complete (the while loop 
in method #createUniquePrefix doesn't iterate/increment anything).

Original issue reported on code.google.com by alex.dob...@gmail.com on 28 Mar 2012 at 4:59

Attachments:

GoogleCodeExporter commented 9 years ago 
whaou can't remember what I've smoked when I coded this... Sorry xD

I'll apply your patch tonight, thank you so much Alex !

Original comment by gael.laz...@gmail.com on 28 Mar 2012 at 5:08

GoogleCodeExporter commented 9 years ago 
LOL dont worry about it.
ps there are some issues related to guice-gin, you mind if i take a look?
if you haven't started already

Original comment by alex.dob...@gmail.com on 28 Mar 2012 at 5:11

GoogleCodeExporter commented 9 years ago 
Of course you can ! I'm too busy right now to have a look to it :/

Original comment by gael.laz...@gmail.com on 28 Mar 2012 at 7:17

GoogleCodeExporter commented 9 years ago 
I just deployed a new 0.37-SNAPSHOT with your patch, but not on forge.octo.com 
anymore, but on sonatype OSS maven repository.

In your pom.xml, you have to replace the <id>snapshot-forge.octo.com</id> 
repository with :

 <repositories>
    <repository>
      <id>sonatype-snapshots</id>
      <url>http://oss.sonatype.org/content/repositories/snapshots</url>
      <snapshots><enabled>true</enabled></snapshots>
      <releases><enabled>false</enabled></releases>
    </repository>
  <repositories>

Could you please give it a try ?

Original comment by gael.laz...@gmail.com on 28 Mar 2012 at 9:38

GoogleCodeExporter commented 9 years ago 
first thing tomorrow :)

Original comment by alex.dob...@gmail.com on 28 Mar 2012 at 10:17

GoogleCodeExporter commented 9 years ago 
Did you install the artifact in that repo? I can't find it there.

On Thu, Mar 29, 2012 at 1:16 AM, Alex Dobjanschi
<alex.dobjanschi@gmail.com>wrote:

Original comment by alex.dob...@gmail.com on 29 Mar 2012 at 8:35

GoogleCodeExporter commented 9 years ago 
This is weird, it is available when browsing the repository through http : 
https://oss.sonatype.org/content/repositories/snapshots/com/googlecode/gwt-test-
utils/

Original comment by gael.laz...@gmail.com on 29 Mar 2012 at 8:39

GoogleCodeExporter commented 9 years ago 
Looks fine to me :)

I searched for "gwt", "gwt-test", and some other keywords, but not
"gwt-test-utils".

Great job man!

Original comment by alex.dob...@gmail.com on 29 Mar 2012 at 8:46

GoogleCodeExporter commented 9 years ago 
Thank you very much for your feedback and for your patch !

Original comment by gael.laz...@gmail.com on 29 Mar 2012 at 8:50