google-code-export / gwt-test-utils

Automatically exported from code.google.com/p/gwt-test-utils
1 stars 0 forks source link

Patch for DOMImpl.hasAttribute() is missing #64

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
DOMImplPatcher does not patch DOMImpl's native hasAttribute().

The patch as we did it:

@PatchMethod(override = true)
static boolean hasAttribute(final Object domImpl, final Element element, String 
attribute) {
  attribute = JsoProperties.get().getPropertyName(attribute);
  final PropertyContainer properties = JavaScriptObjects.getObject(element, JsoProperties.ELEM_PROPERTIES);
  return properties.contains(attribute) || properties.contains(attribute.toLowerCase());
}

Version: gwt-test-utils-0.28.6-20110809.075218-9

Original issue reported on code.google.com by stefan.s...@googlemail.com on 11 Aug 2011 at 9:33

GoogleCodeExporter commented 9 years ago

Original comment by gael.laz...@gmail.com on 11 Aug 2011 at 9:43

GoogleCodeExporter commented 9 years ago
See http://code.google.com/p/gwt-test-utils/issues/detail?id=63.

Could you please confirm DOM methods are working now ?

Original comment by gael.laz...@gmail.com on 14 Aug 2011 at 4:58

GoogleCodeExporter commented 9 years ago
Fix looks good over here.

Original comment by stefan.s...@googlemail.com on 15 Aug 2011 at 1:09

GoogleCodeExporter commented 9 years ago
thx :-)

Original comment by gael.laz...@gmail.com on 15 Aug 2011 at 1:36

GoogleCodeExporter commented 9 years ago

Original comment by gael.laz...@gmail.com on 13 Sep 2011 at 5:50