google-code-export / gwt-test-utils

Automatically exported from code.google.com/p/gwt-test-utils
1 stars 0 forks source link

Patches to enhance mocking of URL, Location, XMLParser, and UIBinder #83

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I am attaching a patch file that makes the following changes:
* add support for <cell> elements in UIBinder templates
* expose access to child widgets in UIBinderElement
* add URL.encodePathSegmentImpl
* add support for setting the url used by Location
* add missing XMLParserImpl methods: createTextNode, getOwnerDocument, 
setAttribute

Original issue reported on code.google.com by snstan...@gmail.com on 21 Oct 2011 at 11:48

Attachments:

GoogleCodeExporter commented 9 years ago
Thank you very much for your contribution ! I will check and add those changes 
in the coming days, so stay tuned :)

Original comment by gael.laz...@gmail.com on 24 Oct 2011 at 5:31

GoogleCodeExporter commented 9 years ago

Original comment by gael.laz...@gmail.com on 27 Oct 2011 at 6:31

GoogleCodeExporter commented 9 years ago
Based on the patch you've provided, I made changes to support :

 * URL.encodePathSegmentImpl
 * setting the url used by Location
 * missing XMLParserImpl methods: createTextNode, getOwnerDocument, setAttribute

I deployed new 0.35-SNAPSHOT, 0.33.1-SNAPSHOT, 0.28.8-SNAPSHOT, 0.25.5-SNAPSHOT 
and 0.22.5-SNAPSHOT with those changes.

I will add your changes on UiBinder support in the next couple of days :)

Original comment by gael.laz...@gmail.com on 27 Oct 2011 at 7:30

GoogleCodeExporter commented 9 years ago
UiBinder enhancement are now available on the lastest snasphots I've just 
deployed.
Although it was a good way to start, I didn't use your patch for those 
modifications since I had another issue with UiBinder which requiered some 
design refactorting 
(http://code.google.com/p/gwt-test-utils/issues/detail?id=84)

Could you please give it a try to validate each feature works fine for you and 
give me some feedback so I could close this issue ?
Many thanks for your help :)

Original comment by gael.laz...@gmail.com on 3 Nov 2011 at 7:57

GoogleCodeExporter commented 9 years ago
Looks good to me.

Original comment by snstan...@gmail.com on 12 Nov 2011 at 4:57

GoogleCodeExporter commented 9 years ago

Original comment by gael.laz...@gmail.com on 12 Nov 2011 at 10:46