google-code-export / hfm-net

Automatically exported from code.google.com/p/hfm-net
1 stars 0 forks source link

For clients that write "Completed xxxxx out of xxxxxx steps (xx%)" ignore any frames that do not occur on the whole %. #98

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

- For example, the following lines:

[15:45:53] Completed 87150 out of 250000 steps  (34%)
[15:46:41] Completed 87500 out of 250000 steps  (35%)

The first is a completed frame write after a client has been restarted. 
This is obviously in the middle of the 34% "frame".  Then the frame
completes rather quickly.  In this case HFM thinks the entire 34% frame did
complete in 48 seconds.  This can be a problem in two areas, PPD
calculation and benchmarks.  The later with the minimum frame time that is
persisted and also with the running queue of the last three hundred
observed frame durations.

Last Version Tested - v0.4.0.62

Original issue reported on code.google.com by harlam357 on 11 Oct 2009 at 9:14

GoogleCodeExporter commented 9 years ago

Original comment by harlam357 on 14 Oct 2009 at 6:41

GoogleCodeExporter commented 9 years ago

Original comment by harlam357 on 15 Oct 2009 at 1:09

GoogleCodeExporter commented 9 years ago
Marked Fixed for Revision 64.  Now checking the number of steps completed vs. 
the
total number of steps.  If the computed percentage deviates more than 0.1 vs the
printed percentage in the frame log line then the frame will not be saved into 
the
UnitFrame data array.

// ex. [00:19:40] Completed 82499 out of 250000 steps  (33%) - Would Validate
//     [00:19:40] Completed 82750 out of 250000 steps  (33%) - Would Validate
// 10% frame step tolerance. In the example the completed must be within 250 
steps.

Original comment by harlam357 on 17 Oct 2009 at 3:35

GoogleCodeExporter commented 9 years ago

Original comment by harlam357 on 19 Oct 2009 at 2:04