google-code-export / labyrinth

Automatically exported from code.google.com/p/labyrinth
GNU General Public License v2.0
2 stars 0 forks source link

generic usability enhancements in glade file #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
[Patch!]

Here is some very quick reorganizing I did in glade3 on labyrinth's glade
files. This is after posting my flood of comments on
http://live.gnome.org/MindMapping/Labyrinth

I have not tested if it works (I am only running the edgy eft .deb provided
on the website), but I think the generic idea is here (and it might work
too). Tell me what you think. Oh, I added a "convert" button, that would be
for the export function (like, export the map to PNG, etc). "convert"
sounds correct to me, but I may be crazy too.

There is a label "menu goes here", basically I suggest putting the menu
there (it is currently in the "current mind map" windows), unless you have
special plans to make it relevant to the "current mind map" windows.

Original issue reported on code.google.com by nekoh...@gmail.com on 18 Oct 2006 at 9:16

Attachments:

GoogleCodeExporter commented 9 years ago
Hi,
  I'm unable to apply the patch (pebkac, I think) - could you please provide the
whole glade file?

Original comment by andreas....@gmail.com on 18 Oct 2006 at 9:35

GoogleCodeExporter commented 9 years ago
Here it is.

Original comment by nekoh...@gmail.com on 18 Oct 2006 at 9:43

Attachments:

GoogleCodeExporter commented 9 years ago
Okay.  I've spent a little time examining the patch.

Attached is a (fairly large) patch against SVN trunk that incorporates the 
proposed
changes.  I'd like to know what people think before committing.

I've moved the "About" dialog out from map windows to the browser.  I added a 
menu
bar to the browser window and hooked up all the needed signals and such so that 
the
correct menu items are sensitive at the correct times.

One thing I did change was the "Convert".  That doesn't feel quite right to me, 
so
I've changed the menu entry and toolbar item to "Export" which (I think) fits 
better.
 Still uses the same stock icon though.  The mechanism is a little bulky at the
moment (it basically creates the window, doesn't show it and calls the "export"
callback manually).  If and when more export options become available, a small 
dialog
can be added to offer the choice of export options from this.

Finally, if you want you're name to appear in the changelog (currently it's
"nekohayo"), please let me know and I'll add it.

Patch is against current trunk (revision 74).  Thanks.

Original comment by DonScor...@gmail.com on 19 Oct 2006 at 2:55

Attachments:

GoogleCodeExporter commented 9 years ago
I made a new version from today's revision 115. Uses stock toolbar items. Works 
for
me, and I like it a bit better like this. Do you think it's any good?

Original comment by nekoh...@gmail.com on 6 Nov 2006 at 1:37

Attachments:

GoogleCodeExporter commented 9 years ago
Hi,

I've combined the older version (mostly the code) with the version added today 
(most
of the glade stuff) and committed it to SVN.  I added a menubar to the top of 
the
window as well, as it felt like it was missing something (and it allows the
Help->About to be moved to the Browser window).

2006-11-06 Don Scorgie <DonScorgie@Blueyonder.co.uk>

        * src/MainWindow.py:
        * src/Browser.py:
        * src/utils.py:
        * data/labyrinth-ui.xml:
        * data/labyrinth.glade:
        New, improved Browser window
        Move "Help->About" to Browser window.  Remove from map windows
        Based heavily on a patch from Jean-François Fortin Tam.  Issue #15

(Hope I got the name right.  If its wrong, please let me know and I'll change 
it)

Closing.

Original comment by DonScor...@gmail.com on 6 Nov 2006 at 3:28

GoogleCodeExporter commented 9 years ago
You got the name right ;)

Here is a minor fix on your current .glade file (patch attached). I removed a 
setting
that forced the toolbar icon styles. If you remove that property, it uses the 
gnome
setting, which is nicer I think.

Original comment by nekoh...@gmail.com on 6 Nov 2006 at 7:43

Attachments: