google-code-export / leonardosketch

Automatically exported from code.google.com/p/leonardosketch
1 stars 0 forks source link

Missing shadow when duplicating shapes (e.g. as symbols) #89

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. create a rectangle with shadow
2. add this rectangle as symbol

What is the expected output? What do you see instead?
The symbol should have a shadow, but does not.

What version of the product are you using? On what operating system?
Current Build of 2012-11-11

Please provide any additional information below.

Fix:
in class SShape (package org.joshy.sketch.model) in method duplicate add a line 
to set the shadow:

    public SNode duplicate(SNode dupe) {
        if(dupe == null) throw new IllegalArgumentException("SShape.duplicate: duplicate shape argument can't be null!");
        ((SShape)dupe).setFillPaint(this.getFillPaint().duplicate());
        ((SShape)dupe).setFillOpacity(this.getFillOpacity());
        ((SShape)dupe).setStrokePaint(this.getStrokePaint());
        ((SShape)dupe).setStrokeWidth(this.getStrokeWidth());
        ((SShape)dupe).setShadow(this.getShadow()); // TODO change here
        return super.duplicate(dupe);
    }

Original issue reported on code.google.com by mehl.b...@gmail.com on 12 Nov 2012 at 1:27

GoogleCodeExporter commented 9 years ago
attached the patch file ...

Original comment by mehl.b...@gmail.com on 12 Nov 2012 at 2:08

Attachments: