search

google-code-export / los-cocos

Automatically exported from code.google.com/p/los-cocos
Other
1 stars 0 forks source link

grid effect partially broken in cocos svn 865 #124

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. run test_grid_effect_in_layer.py or test_grid_effect_in_sprite.py ( to 
be found in the cocos test directory )
2. Notice that in the first is explicity stated that the ColorLayer must 
be visible all the time

What is the expected output? What do you see instead?
I expected what was described in the test, instead the ColorLayer 
disapears.
Note that the second test dont states anything, but in cocos 0.3.0 the 
background remains visible; instead, with cocos trunk svn 865 the 
background also disapears.

What version of the product are you using? On what operating system?
win XP - python 2.6 - pyglet 1.1.3 release - cocos svn trunk 865

Please provide any additional information below.
grid effect partially broken in cocos svn 865, was working ok in cocos 
0.3.0 release.
win XP - python 2.6 - pyglet 1.1.3 release

Original issue reported on code.google.com by ccanepacc@gmail.com on 30 Jul 2009 at 11:05

GoogleCodeExporter commented 9 years ago 
follow up:

similar visibility problems shows in cocos svn trunk 865 at tests

test_multiple_grid_effects.py -> same as others
test_transition_corner_move.py -> background not visible until the transform 
ends 
(works ok in cocos 0.3.0 release )
test_transition_fadebl.py -> idem
test_transition_fadetr.py -> idem
test_transition_fadeup.py -> idem
test_transition_turnofftiles.py -> idem

The problem was introduced at r 768, in framegrabber.py, by forcing as 
framegrabber 
the GenericGrabber; previously the FBOGrabber was used.
From the commented out lines near line 64, seems that the intention was to 
select 
the FBOGrabber and fallback to the generic if FBOs not available.

A quick test flipping the comment out status in lines 64-65 shows that all 
failing 
tests now runs normally.

Original comment by ccanepacc@gmail.com on 1 Aug 2009 at 3:14

GoogleCodeExporter commented 9 years ago 
r922 restored the cocos 0.3.0release behavior
Grid effects will be available if FBOs are available.

framegrabber.py has additional code to fallback when no FBOs, but this codepath 
seems 
incomplete. It would be nice to have that code working, but is low priority 
just now.

Original comment by ccanepacc@gmail.com on 19 May 2010 at 4:01