search

google-code-export / lusca-cache

Automatically exported from code.google.com/p/lusca-cache
0 stars 0 forks source link

range_offset_limit doesn't work as intended #51

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The range_offset_limit doesn't seem to work. In particular, setting it to
-1 doesn't work at all.

Original issue reported on code.google.com by adrian.c...@gmail.com on 10 Aug 2009 at 4:30

GoogleCodeExporter commented 9 years ago 
The use of httpHdrRangeOffsetLimit() seems to be rather incorrect.

If range_offset_limit is -1, the function always returns false - ie, ranges are
-always- allowed.

The problem is that the configuration option == -1 should mean "always fetch the
object from the beginning" and it is being used for slightly different meanings 
in
the client-side and server-side code.

Specifically in the server-side code (src/http.c), it is used to determine 
whether
the proxy will satisfy the range request and just fetch the whole object, or 
whether
it will forward the range request and just hand the reply to the client without
caching it. range_offset_limit == -1 translates to "always allow the range", 
which
the code treats as "we aren't going to handle this range ourselves; just 
forward it on."

Original comment by adrian.c...@gmail.com on 10 Aug 2009 at 5:35

GoogleCodeExporter commented 9 years ago 
Temporary hack workaround in r14266. I need to fix this!!

Original comment by adrian.c...@gmail.com on 10 Aug 2009 at 5:40