google-code-export / mgwt

Automatically exported from code.google.com/p/mgwt
Other
1 stars 0 forks source link

Please add blur handler support to MValueBoxBase #138

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Here's the patch:

diff --git 
a/src/main/java/com/googlecode/mgwt/ui/client/widget/base/MValueBoxBase.java 
b/src/main/java/com/googlecode/mgwt/ui/client/widget/base/MValueBoxBase.java
index e121478..65d1541 100644
--- a/src/main/java/com/googlecode/mgwt/ui/client/widget/base/MValueBoxBase.java
+++ b/src/main/java/com/googlecode/mgwt/ui/client/widget/base/MValueBoxBase.java
@@ -26,6 +26,7 @@ import com.google.gwt.event.dom.client.FocusEvent;
 import com.google.gwt.event.dom.client.FocusHandler;
 import com.google.gwt.event.dom.client.HasAllKeyHandlers;
 import com.google.gwt.event.dom.client.HasChangeHandlers;
+import com.google.gwt.event.dom.client.HasBlurHandlers;
 import com.google.gwt.event.dom.client.HasFocusHandlers;
 import com.google.gwt.event.dom.client.KeyDownHandler;
 import com.google.gwt.event.dom.client.KeyPressHandler;
@@ -73,7 +74,7 @@ import com.googlecode.mgwt.ui.client.widget.touch.TouchPanel;
  * @author Daniel Kurka
  */
 public class MValueBoxBase<T> extends Composite implements HasTouchHandlers, HasPlaceHolder, HasAutoCapitalize, HasAutoCorrect, HasChangeHandlers, HasName, HasDirectionEstimator, Ha
-               AutoDirectionHandler.Target, IsEditor<ValueBoxEditor<T>>, 
HasAllKeyHandlers, HasFocusHandlers {
+               AutoDirectionHandler.Target, IsEditor<ValueBoxEditor<T>>, 
HasAllKeyHandlers, HasFocusHandlers, HasBlurHandlers {

        private TouchPanel main;
        protected final ValueBoxBase<T> box;
@@ -596,6 +597,11 @@ public class MValueBoxBase<T> extends Composite implements 
HasTouchHandlers, Has
        public HandlerRegistration addFocusHandler(FocusHandler handler) {
                return box.addFocusHandler(handler);
        }
+       
+       @Override
+       public HandlerRegistration addBlurHandler(BlurHandler handler) {
+               return addBlurHandler(handler);
+       }

        public void setFocus(boolean b) {
                box.setFocus(b);

Original issue reported on code.google.com by rob...@cloud2market.com on 11 Feb 2012 at 6:24

GoogleCodeExporter commented 9 years ago
Oops.  There was a typo in my patch.  This diff is the correct one:

diff --git 
a/src/main/java/com/googlecode/mgwt/ui/client/widget/base/MValueBoxBase.java 
b/src/main/java/com/googlecode/mgwt/ui/client/widget/base/MValueBoxBase.java
index e121478..94c629f 100644
--- a/src/main/java/com/googlecode/mgwt/ui/client/widget/base/MValueBoxBase.java
+++ b/src/main/java/com/googlecode/mgwt/ui/client/widget/base/MValueBoxBase.java
@@ -26,6 +26,7 @@ import com.google.gwt.event.dom.client.FocusEvent;
 import com.google.gwt.event.dom.client.FocusHandler;
 import com.google.gwt.event.dom.client.HasAllKeyHandlers;
 import com.google.gwt.event.dom.client.HasChangeHandlers;
+import com.google.gwt.event.dom.client.HasBlurHandlers;
 import com.google.gwt.event.dom.client.HasFocusHandlers;
 import com.google.gwt.event.dom.client.KeyDownHandler;
 import com.google.gwt.event.dom.client.KeyPressHandler;
@@ -73,7 +74,7 @@ import com.googlecode.mgwt.ui.client.widget.touch.TouchPanel;
  * @author Daniel Kurka
  */
 public class MValueBoxBase<T> extends Composite implements HasTouchHandlers, HasPlaceHolder, HasAutoCapitalize, HasAutoCorrect, HasChangeHandlers, HasName, HasDirectionEstimator, Ha
-               AutoDirectionHandler.Target, IsEditor<ValueBoxEditor<T>>, 
HasAllKeyHandlers, HasFocusHandlers {
+               AutoDirectionHandler.Target, IsEditor<ValueBoxEditor<T>>, 
HasAllKeyHandlers, HasFocusHandlers, HasBlurHandlers {

        private TouchPanel main;
        protected final ValueBoxBase<T> box;
@@ -596,6 +597,11 @@ public class MValueBoxBase<T> extends Composite implements 
HasTouchHandlers, Has
        public HandlerRegistration addFocusHandler(FocusHandler handler) {
                return box.addFocusHandler(handler);
        }
+       
+       @Override
+       public HandlerRegistration addBlurHandler(BlurHandler handler) {
+               return box.addBlurHandler(handler);
+       }

        public void setFocus(boolean b) {
                box.setFocus(b);

Original comment by rob...@cloud2market.com on 11 Feb 2012 at 6:32

GoogleCodeExporter commented 9 years ago
This fixed the return key issue that I complained about a while back.

Original comment by rob...@cloud2market.com on 11 Feb 2012 at 6:37

GoogleCodeExporter commented 9 years ago

Original comment by kurka.da...@gmail.com on 11 Feb 2012 at 3:29

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 180f0fe85e94.

Original comment by kurka.da...@gmail.com on 11 Feb 2012 at 7:13

GoogleCodeExporter commented 9 years ago

Original comment by kurka.da...@gmail.com on 11 Feb 2012 at 7:13

GoogleCodeExporter commented 9 years ago

Original comment by kurka.da...@gmail.com on 7 May 2012 at 9:30

GoogleCodeExporter commented 9 years ago

Original comment by kurka.da...@gmail.com on 17 Jun 2012 at 3:12