google-code-export / microblog-purple

Automatically exported from code.google.com/p/microblog-purple
GNU General Public License v3.0
2 stars 0 forks source link

Cannot compile when pidgin is configured with "--without-x" #232

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Configure pidgin with "--without-x"
2. Install pidgin
3. Try to compile microblog-purple

What is the expected output? What do you see instead?
twitgin.c:44:21: fatal error: gtkconv.h: No such file or directory
compilation terminated.

What version of the product are you using? On what operating system?
Pidgin 2.7.10
microblog-purple r382

Please provide any additional information below.
I only use the console finch client, not the graphical pidgin client.

Original issue reported on code.google.com by chaz6....@gmail.com on 21 Feb 2011 at 4:41

GoogleCodeExporter commented 9 years ago
Edit configure.mak, set "BUILD_TWITGIN = twitgin" to "BUILD_TWITGIN = "

Original comment by andresen.nils@gmail.com on 21 Feb 2011 at 6:21

GoogleCodeExporter commented 9 years ago
Thanks, and in order to install I had to make the following changes:-

--- global.mak  (revision 382)
+++ global.mak  (working copy)
@@ -73,15 +73,20 @@

 IS_PIDGIN = $(shell pkg-config --atleast-version=2.0 pidgin && echo 1 || echo 0)
 IS_CARRIER = $(shell pkg-config --atleast-version=2.0 carrier && echo 1 || echo 0)
+IS_FINCH = $(shell pkg-config --atleast-version=2.0 finch && echo 1 || echo 0)

 ifeq ($(strip $(IS_PIDGIN)), 1)
-       PIDGIN_NAME := pidgin
-else
+       PIDGIN_NAME := pidgin
+else
 ifeq ($(strip $(IS_CARRIER)), 1)
         PIDGIN_NAME := carrier
+else
+ifeq ($(strip $(IS_FINCH)), 1)
+        PIDGIN_NAME := finch
 endif
 endif

+
 PREFIX := $(shell pkg-config --variable=prefix $(PIDGIN_NAME) 2> /dev/null || echo /usr)
 LIBDIR := $(shell pkg-config --variable=libdir $(PIDGIN_NAME) 2> /dev/null || echo $(PREFIX)/lib)

@@ -90,7 +95,7 @@
 PURPLE_DATAROOT_DIR = $(shell pkg-config --variable=datarootdir purple)
 PURPLE_CFLAGS = $(CFLAGS) -DPURPLE_PLUGINS -DENABLE_NLS -DMBPURPLE_VERSION=\"$(VERSION)$(SUBVERSION)\"
 PURPLE_CFLAGS += $(shell pkg-config --cflags purple)
-PURPLE_CFLAGS += $(shell pkg-config --cflags pidgin)
+PURPLE_CFLAGS += $(shell pkg-config --cflags $(PIDGIN_NAME))
 #PURPLE_CFLAGS += -Wall -pthread -I. -g -O2 -pipe -fPIC -DPIC
 PURPLE_CFLAGS += -Wall -pthread -I. -g -pipe -fPIC -DPIC
 PLUGIN_SUFFIX := .so

Original comment by maken...@gmail.com on 21 Feb 2011 at 8:57

GoogleCodeExporter commented 9 years ago
Oops, missing an endif, but you get the gist.

Original comment by maken...@gmail.com on 21 Feb 2011 at 8:59

GoogleCodeExporter commented 9 years ago
Thanks for the report.
Please always use a new issue, if the original problem has been solved.
I created a new issue for your request as issue 233
Maybe you could attach your patch (including that missing endif) as a 
patch-file for convenience. 

Original comment by andresen.nils@gmail.com on 22 Feb 2011 at 5:31