search

google-code-export / minimalist-gmail

Automatically exported from code.google.com/p/minimalist-gmail
1 stars 1 forks source link

Keyboard toggle for Google Bar and Header work only once #310

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Which Minimalist for Gmail option is causing the problem?
'Hide Google Bar' and 'Hide header'

What is the problem? Describe completely:
The description of each options is explanatory: [ \ ] is a keyboard shortcut to 
toggle the option but only one is active (usually the Google Bar).

See:
Hide Google Bar
[ \ ] or click blank stripe to toggle

Hide header
Click blank stripe to toggle, [ / ] to focus search, [ \ ] to toggle

Does the problem persist when loading Gmail with this link:
https://mail.google.com/mail/u/0/?labs=0 if not, list your enabled labs 
experiments: - persists

MinGmail version       - 1.7.36
Chrome version         - 12.0.742.100
Chrome update channel  -
Operating System       - WXP Pro
Language               - EN
Google apps user?      - Yes
Other Gmail extensions - disabled during testing

Please provide any additional information below and attach screenshots if 
possible.

Related to: Issue 204 (could solve this)

Original issue reported on code.google.com by gerardol...@gmail.com on 29 Jun 2011 at 8:50

GoogleCodeExporter commented 9 years ago 
This in not a conflict. If only one feature is active, the shortcut will toggle 
the feature. If both are active it will toggle both (toggle stripes also are 
combined when both features are active.)

Original comment by anst...@gmail.com on 29 Jun 2011 at 2:09

GoogleCodeExporter commented 9 years ago 
It is a conflict, but probably not what I described.

It works as you said in my Gapps account (still old style).

On my gmail account (new style) it only works once, to show the Google Bar 
only, and no longer responds to subsequent strokes of \. (Header is always 
hidden).

Tried with labs=0 and classic theme - same results.

Original comment by gerardol...@gmail.com on 29 Jun 2011 at 2:55

GoogleCodeExporter commented 9 years ago 
Oh I see what you mean. I just tested and it's still working fine for me.

Are you getting any JavaScript errors when the toggle fails?

  [wrench] > Tools > JavaScript Console > Errors

Original comment by anst...@gmail.com on 29 Jun 2011 at 3:52

GoogleCodeExporter commented 9 years ago 
All done on labs=0

only google bar, refresh: (no error)

only header, refresh: errors - doesn't work (works on normal mode)
MINIMALIST GMAIL: **MAIN LOOP**

chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:137
MINIMALIST GMAIL: hiding header and adding toggle...

chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:142
Uncaught TypeError: Cannot read property 'parentNode' of undefined

run
chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:142
E.add
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:332
$GU
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:1425
$9_
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:1542
$_W
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:1456
$MSb
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:2035
(anonymous function)
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:23
kAa
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:804
(anonymous function)
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:23
Aua
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:710
$Ry
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:1119
Kta
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:694
$Qy
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:1119
cva
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:717
(anonymous function)
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:23
mAa.kc
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:1252
(anonymous function)
/mail/u/0/?ui=2&view=js&name=main,tlist,ptlist&ver=6bSae_YWk2o.pt_PT.&am=!STRING
REPLACED:2038
chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:556

chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:518
Uncaught TypeError: Cannot read property 'nextSibling' of null
toggleHeader
chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:518
keypress
chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:619

bar and header, refresh: (reported error)
chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:503
Uncaught TypeError: Cannot read property 'firstChild' of null
toggle Header
chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:503
keypress
chrome-extension://oddhbkghjoccbljmagcgoklbfdjeiinb/js/active.js:619

Original comment by gerardol...@gmail.com on 29 Jun 2011 at 4:14

GoogleCodeExporter commented 9 years ago 
Yeah I see a couple errors in there that I would expect to see for this kind of 
behavior. Not sure what's triggering them to work once though. I'll keep at eye 
on this one. It's likely that your code is slightly different than mine as a 
result of all the updates Google is making.

Original comment by anst...@gmail.com on 29 Jun 2011 at 4:27

GoogleCodeExporter commented 9 years ago 
Minimalist updated to version: 1.7.37.

No change. Issue still remains.

Original comment by gerardol...@gmail.com on 1 Jul 2011 at 7:09

GoogleCodeExporter commented 9 years ago 
As of today, the issue is resolved (after UI change from Google+).

Version: 1.7.40
GC: 12.0.742.112 (WinXP Pro 2002 SP3).

Original comment by gerardol...@gmail.com on 12 Jul 2011 at 1:01

GoogleCodeExporter commented 9 years ago

Original comment by anst...@gmail.com on 12 Jul 2011 at 2:16

GoogleCodeExporter commented 9 years ago 
This still does not work in my google apps account. I've tried classic, preview 
and preview (dense) themes non work correctly. I hide google bar and header. 
When I click or use \ to toggle only the google bar shows, the header does not. 
And then I cannot hide the google bar again.

My other normal google gmail accounts work fine.

Original comment by board...@lazybum.com on 12 Jul 2011 at 8:24

GoogleCodeExporter commented 9 years ago 
Same issue still occurs for my Apps account with version 1.7.40 (Chrome ver 
13.0.782.55). Clicking on the thin blank space only shows the hidden google 
bar, with the header remaining hidden; subsequent clicks do absolutely nothing.

Original comment by sba...@bakerits.co.uk on 14 Jul 2011 at 8:40