google-code-export / minimalist-gmail

Automatically exported from code.google.com/p/minimalist-gmail
1 stars 1 forks source link

Ads div not hidding #390

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Which Minimalist for Gmail option is causing the problem?
Hiding the ads and contacts on the right of the message

What is the problem? Describe completely:
I have installed the Labs "Preview Pane" wich is the "outlook style" option in 
the Labs.
The right nav bar that is shown with contacts and ads is blank but not hiding.

Does the problem persist when loading Gmail with this link:
https://mail.google.com/mail/u/0/?labs=0 if not, list your enabled labs
experiments:
- Move Icon Column by Greg B
- Preview Pane by Peter B & Michael K
- Unread message icon by Manu C

MinGmail version       - downloaded yesterday
Chrome version         - 14.0.835.202 m
Chrome update channel  -
Operating System       - Windows 7 x64
Language               - French
Google apps user?      -
Other Gmail extensions -

Please provide any additional information below and attach screenshots if
possible.
To correct it, I've add this snippet in active.js in the if on line 48 :
if (getLoad()[0] == cP) {
    var tr = document.querySelectorAll("table.Bs.nH.dFFoge.dGpsQd.id > tr");
    var tds = document.querySelectorAll("table.Bs.nH.dFFoge.dGpsQd.id > tr > td.Bu");
    if (tds.length > 1)
        tr[0].removeChild(tds[1]);
    return;
}

It's definetly not the best way of doing it, and I don't know if it breaks 
something else, but its working for now. I don't want to read all code -.-
Have a good day !

Original issue reported on code.google.com by maxfaf...@gmail.com on 26 Oct 2011 at 4:36

Attachments:

GoogleCodeExporter commented 9 years ago
actually, I've end up with a much better way to achieve this.
In stylesheet.js, I've add on line 219 :
css += "table.Bs.nH.dFFoge.dGpsQd.id > tr > td.Bu:last-child { height: 0 
!important; width: 0 !important; visibility: hidden !important; overflow: 
hidden !important; display:none !important;}\n";

removing the TD was creating a "Uncaught CustomError: Error in protected 
function: Cannot read property 'className' of null" by Gmail.

Have a good day !

Original comment by maxfaf...@gmail.com on 27 Oct 2011 at 2:18

GoogleCodeExporter commented 9 years ago
You can add that code in Custom CSS in the General tab without having to edit 
the extension itself.

Also the hide ads feature will note hide the sidebar. If you want to hide the 
whole sidebar you have to use the hide people widget option (which will only 
work if you have NOT hidden the People Widget in Gmail settings.)

Original comment by anst...@gmail.com on 27 Oct 2011 at 9:33

GoogleCodeExporter commented 9 years ago
Ok, excellent. I'll put the code in the General tab.

For the sidebar, the People widget was enabled in Gmail and hidden in the Main 
tab. The "Hide sidebar ads" option was also checked.

Original comment by maxfaf...@gmail.com on 27 Oct 2011 at 10:02

GoogleCodeExporter commented 9 years ago
THIS EXTENSION IS DEPRECATED!

Active development continues at Minimalist for Everything:

https://chrome.google.com/webstore/detail/bmihblnpomgpjkfddepdpdafhhepdbek

The Gmail module for Minimalist for Everything has all the same features of
Minimalist for Gmail and more!

Please disable Minimalist for Gmail if you have it installed and install
Minimalist for Everything instead.

Original comment by anst...@gmail.com on 19 Nov 2011 at 9:05