search

google-code-export / minimalist-google-calendar

Automatically exported from code.google.com/p/minimalist-google-calendar
1 stars 0 forks source link

Today Highlight not taking effect from color picker #4

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Which Minimalist for Google Calendar option is causing the problem?
General > Today Highlight

What is the problem? Describe completely:
I have Today Highlight checked, I select a different color, switch over to 
Google Calendar and refresh, and it still shows the old color. Clicking off the 
color picker before switching doesn't do it either. Unchecking and rechecking 
Today Highlight does it.

Original issue reported on code.google.com by lee...@gmail.com on 7 Feb 2011 at 8:22

GoogleCodeExporter commented 9 years ago 
I've had this issue with ALL color changes.

Original comment by MDNeilson on 8 Feb 2011 at 2:08

GoogleCodeExporter commented 9 years ago 
So the colors don't save until you uncheck and recheck another option?

Original comment by anst...@gmail.com on 8 Feb 2011 at 2:15

GoogleCodeExporter commented 9 years ago 
Yep, that's the tl;dr. And there's no visual feedback of that… yet. :)

Original comment by lee...@gmail.com on 8 Feb 2011 at 2:18

GoogleCodeExporter commented 9 years ago 
Hmm I'm having trouble replicating it on my end. Does the color of the example 
box change on the options page as you are dragging around in the color picker?

Original comment by anst...@gmail.com on 8 Feb 2011 at 2:21

GoogleCodeExporter commented 9 years ago 
Yeah, it does. Not sure if it means anything, but as the settings page loads, I 
see the default blue for an instant before my selection populates. Same for the 
default yellow for Today.

Original comment by lee...@gmail.com on 8 Feb 2011 at 2:23

GoogleCodeExporter commented 9 years ago 
No that's normal. The HTML has the defaults hard-coded into it. The JavaScripit 
then loads the saved preferences and replaces the default values.

Original comment by anst...@gmail.com on 8 Feb 2011 at 2:29

GoogleCodeExporter commented 9 years ago 
I have attached two images. The minimalist is in Chrome 11 (Dev - latest), and 
the IE is from IE8. The Today box clearly isn't highlighted in the Chrome 
Version. It makes it really hard to see. Also, even if I go and change the 
option in Minimalist it doesn't change the highlighting at all on today's date 
box.

Small problem, but it does make it really hard to see without that yellow 
around it.

Original comment by pattont on 20 Feb 2011 at 11:20

Attachments:

GoogleCodeExporter commented 9 years ago 
I just figured out that the highlighting works only if the Dim Weekends is not 
selected.

Original comment by pattont on 20 Feb 2011 at 11:21

GoogleCodeExporter commented 9 years ago 
@pattont
See Issue 21: 
http://code.google.com/p/minimalist-google-calendar/issues/detail?id=21

Currently, Dim Weekends takes precedent over Today Highlighting. Until I get 
that bug fixed, I would disable Dim Weekends.

Original comment by anst...@gmail.com on 20 Feb 2011 at 11:23