google-code-export / mobbler

Automatically exported from code.google.com/p/mobbler
0 stars 0 forks source link

Last.fm pages localization setting #700

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Even if I'm using the italian localization, when I open the biography page in 
the plus main menu, it loads the english version of the biography. This doesn't 
happen when I open it within the "Visit Last.fm" menu, since it shows correctly 
the italian page.
It'd be better to show the localized version of last.fm, and fallback to the 
english one if there is none.
Moreover, the user should be able to control this behavior by setting the 
default and, eventually, fallback language.

Original issue reported on code.google.com by maurizio...@gmail.com on 25 Nov 2010 at 5:55

GoogleCodeExporter commented 9 years ago
Yes, this is something that was overlooked. We can ask Last.fm for a biography 
in a specific language, and it'd be easy to do that. 

If a given translation isn't available, it returns an empty translation, so 
it'd be bit more work to then get the English one, which of course could also 
be empty.

I'm not sure about having a setting for this, but rather to try and use the 
current language.

Original comment by hugovk@gmail.com on 26 Nov 2010 at 11:51

GoogleCodeExporter commented 9 years ago

Original comment by hugovk@gmail.com on 26 Nov 2010 at 11:51

GoogleCodeExporter commented 9 years ago
Yes, it should be relatively easy to implement this. Assigning it to myself. 

Hugovk, when is the next version of Mobbler out, I'll see if I can get it done 
by then if it's not too soon?

Original comment by gw111zz@gmail.com on 3 Dec 2010 at 9:56

GoogleCodeExporter commented 9 years ago
Well, we were more or less ready to get the beta out through Symbian Horizon, 
but now Horizon is being shut down with the rest of Symbian.org, so we're going 
to put it through Ovi Store ourselves now it only costs 1€ to register. 
Eartle's in the process of convincing Nokia he is who he claims he is, and 
printing long documents, signing them, scanning them and emailing them back. 
And then we want to get Mobbler transferred from the old Horizon account in the 
Ovi Store to the new Mobbler one to preserve reviews and download counts, if 
that's possible...

To summarise, we're pretty much ready for a release, but I reckon the fun admin 
stuff is going to take a couple of weeks at the very least. I'll keep you 
updated.

Original comment by hugovk@gmail.com on 3 Dec 2010 at 10:05

GoogleCodeExporter commented 9 years ago
Hugovk, eartle, I've implemented the feature in changesets b68e4685ad and 
9852c64710.
I've tested in German and French and Hugovk has tested it in French.

As Hugovk has pointed out, not all artists have an entry in every language so 
then only the tags, similar artists and picture appears. In this situation, the 
Last.fm site doesn't show the biography in another available language and tells 
the user that a biography isn't available, so maybe we should do the same?

Original comment by gw111zz@gmail.com on 20 Dec 2010 at 8:47

GoogleCodeExporter commented 9 years ago
I don't know how exactly you render the information, is it too hard to make a 
localized text that links to the english page *if* it exists, instead of ? Sort 
of "There's no biography in xyz language, do you want to see the english one?", 
obviously localized.

Original comment by maurizio...@gmail.com on 21 Dec 2010 at 1:23

GoogleCodeExporter commented 9 years ago
Well, it would be nice to check if the first choice biography is empty, and if 
so, try the English one (if not already checked), but of course this adds more 
complexity, and even then the English one could also be empty.

Original comment by hugovk@gmail.com on 21 Dec 2010 at 1:00

GoogleCodeExporter commented 9 years ago
Yes, that can be done. It could make a second request and show the English 
biography if there is no localised one. 

Original comment by gw111zz@gmail.com on 21 Dec 2010 at 8:35

GoogleCodeExporter commented 9 years ago
Done in revision 9838ee52f. The English biography is displayed if no localised 
version exists.

Original comment by gw111zz@gmail.com on 24 Dec 2010 at 5:30

GoogleCodeExporter commented 9 years ago
Looks good, I'll mark this issues as fixed.

Original comment by hugovk@gmail.com on 26 Dec 2010 at 6:32