google-code-export / musicpm

Automatically exported from code.google.com/p/musicpm
0 stars 0 forks source link

Lyrics often not found #82

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
In many cases the 'view song details' option returns a "No Lyrics" in the
Lyrics Section. However when I query  Lyricsfly myself, the lyrics are
available. Are there any pre-requisities in the song's tags, etc, that have
to be met in order for the lyrics lookup to work in Minion?
Many thanks.

Original issue reported on code.google.com by ton.hoge...@gmail.com on 24 May 2010 at 9:38

GoogleCodeExporter commented 9 years ago
Hi Ton,

Yes, it's important to have tags properly set if you want to retrieve the 
lyrics.
At the moment, the artist and the track title are used in order to retrieve the 
lyrics.
Do you have any examples I could use to check if there's any problems ?

Thanks

Original comment by aurelien...@gmail.com on 24 May 2010 at 7:22

GoogleCodeExporter commented 9 years ago
Artists who have the word "The" in the name sometimes are submitted to lyricsfly
without it, or with it appended to the end, such as:

The Band
Band
Band, The

I don't know if what I did is a good idea or not, but it works for me in my VERY
limited testing.

in mpd.js, line 667:

url = url.replace("{Artist}", nsMPM.Nz(item.Artist, '').replace('^The
','').replace(', The$','').replace(/[^A-Za-z0-9]/g, '%'))

Original comment by thereald...@gmail.com on 1 Jun 2010 at 10:03

GoogleCodeExporter commented 9 years ago
Ok, I do understand what problem we have here.
I will implement a smarter way to fetch lyrics.

Thanks

Original comment by aurelien...@gmail.com on 2 Jun 2010 at 2:47

GoogleCodeExporter commented 9 years ago
what I MEANT to say was...

url = url.replace("{Artist}", nsMPM.Nz(item.Artist,
'').replace(/^The\s?/i,'%').replace(/,?\s?The$/i,'%').replace(/[^A-Za-z0-9]/g, 
'%'))

Original comment by thereald...@gmail.com on 2 Jun 2010 at 12:58

GoogleCodeExporter commented 9 years ago
i am a dummie but isnt it possible to add more sources to look/seek for he 
lyrics

Original comment by ggkurtk...@gmail.com on 6 Jun 2010 at 12:15