Issues 52 and 55 not completely fixed

[GoogleCodeExporter]

The fix for Issue 52 and 55 needs to include (at least) free_pages,
database_pages and modified_pages as well. Otherwise the command barfs:

# php -q ./ss_get_mysql_stats.php --host xxx --items ac,ab,ad,aa --user yyy
--pass ""
Array
(
    [0] => Array
        (
            [file] => /usr/share/cacti/scripts/ss_get_mysql_stats.php
            [line] => 493
            [function] => tonum
            [args] => Array
                (
                    [0] =>
                )

        )
..... and so on which in turn causes the poller to exit with:
05/07/2009 02:45:11 PM - CMDPHP: Poller[0] Host[9] DS[434] WARNING: Result
from CMD not valid.  Partial Result: Array

MySQL: 5.1.34-percona-log
Cacti: 0.8.7b
Templates: 1.1.2

The attached patch solves the issue for me.

Original issue reported on code.google.com by patrik.k...@vrenninge.se on 7 May 2009 at 1:38

Attachments:

• patch.txt

[GoogleCodeExporter]

Would you mind attaching a copy of your SHOW INNODB STATUS output as a file?

This whole process is the Bad Old Days -- no unit testing.  Time to fix that.

Original comment by baron.schwartz on 7 May 2009 at 1:45

• Changed state: Accepted

[GoogleCodeExporter]

Here you go. From the host running cacti:
# mysql -u XXX -p -h dbhost -e 'show innodb status\G' > show_innodb_status.txt

Original comment by patrik.k...@vrenninge.se on 7 May 2009 at 2:02

Attachments:

• show_innodb_status.txt

[GoogleCodeExporter]

This is fixed in r231, and there is a test suite now so it won't happen again.

Original comment by baron.schwartz on 24 Oct 2009 at 1:18

• Changed state: Fixed