google-code-export / nativelibs4java

Automatically exported from code.google.com/p/nativelibs4java
1 stars 1 forks source link

Java5 project using Java6 @Override syntax #57

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
in Java5 you can't use @Override on an interface method, that's only allowed in 
Java6. This causes failures on compilation. We should also throw into the 
pom.xml an explicit compiler plugin to make certain we're using UTF8 file 
encoding as well as targeting the right platform when deploying the jars. I'm 
leaving it up in the air about whether we want to up the target platform to 
java 1.6, or downgrade to 1.5 and remove the invalid @Override. I've attached a 
diff to the pom targeting 1.5 with the caveat that it'll cause compilation 
failures.

Original issue reported on code.google.com by frac...@gmail.com on 15 Mar 2011 at 6:32

Attachments:

GoogleCodeExporter commented 9 years ago
Hi Jay,

Thanks a lot for your proposal and patch.
There's actually already an explicit compiler plugin block in a parent pom 
(http://code.google.com/p/nativelibs4java/source/browse/trunk/libraries/Parent/p
om.xml).
However, it lacked the encoding setting you've proposed (good practice) and 
it's possible it's not working properly. I'll check and merge ASAP :-)

Cheers
--
zOlive

Original comment by olivier.chafik@gmail.com on 15 Mar 2011 at 11:01

GoogleCodeExporter commented 9 years ago
Hello Jay,

This is fixed in revision #2007 : BridJ now compiles with Java 1.5.
Thanks for your report and your patience

Cheers
--
zOlive

Original comment by olivier.chafik@gmail.com on 26 May 2011 at 9:31

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2008.

Original comment by olivier.chafik@gmail.com on 27 May 2011 at 1:07

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2007.

Original comment by olivier.chafik@gmail.com on 27 May 2011 at 1:32