InnoSetup installer

[GoogleCodeExporter]

Hi

I love Notepad2, but I'm not sure why you want an InnoSetup build?

It'll only take me a few minutes, I'll do it tomorrow night [it's 3:20am now, 
so expect installer within 24 hours!]

Would you also like an NSIS and MakeMSI installer?

Samuel

Original issue reported on code.google.com by samuelma...@gmail.com on 21 Jan 2011 at 4:20

[GoogleCodeExporter]

Thanks but I don't need any help for Inno Setup. I just haven't got the time to 
commit my script yet.
And no I don't like NSIS or MSI installers. One installer is sufficient.

Original comment by XhmikosR on 21 Jan 2011 at 4:51

• Changed state: WontFix
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

If you want to try the current installer, you can find it here. All builds are 
included in the zip file. The old installer will be automatically uninstalled 
before installing the new build.
This is what I'd like to handle a little better, in the case that the 
uninstallation of the old build fails for some reason. And finally, I want to 
add log code to all my custom code so I'd have more details if something goes 
wrong (by running the installer with the /LOG=log.txt parameter).

http://www.mediafire.com/file/iiadi16ov0rtdh4/Notepad2-mod.zip

Original comment by XhmikosR on 21 Jan 2011 at 5:10

[GoogleCodeExporter]

That installer certainly looks good, you've included all the necessary features.

Having an MSI installer will allow Notepad2 to be distributed across a domain 
to many computers through Group Policy.

Are you sure you don't want to include an .msi in this project?

Original comment by samuelma...@gmail.com on 22 Jan 2011 at 1:17

[GoogleCodeExporter]

I just want to keep things simple. Personally I don't need an MSI installer and 
silent switches are already supported with Inno Setup. Plus, I don't have the 
time or the knowledge to maintain an MSI installer.

Anyway, I'll try to finish my Inno Setup script in the next days.

Original comment by XhmikosR on 22 Jan 2011 at 12:03

• Changed title: InnoSetup installer
• Changed state: Accepted

[GoogleCodeExporter]

Maintain the script?

You'll just need to install the MSI 'compiler', and whenever you release a new 
version of Notepad2, just overwrite the old Notepad2.exe from the build 
directory, and recompile my script.

If anything needs to be changed from version to version, it would be the GUID. 
Which is one line and will take me a sentence to teach you how they work and 
where/how to change them.

Original comment by samuelma...@gmail.com on 22 Jan 2011 at 2:35

[GoogleCodeExporter]

Nah, I still don't need it and I don't need to complicate things. Thanks for 
the offer.

Original comment by XhmikosR on 22 Jan 2011 at 2:47

[GoogleCodeExporter]

kk

Original comment by samuelma...@gmail.com on 22 Jan 2011 at 3:07

[GoogleCodeExporter]

Unfortunately I lost my working tree with the installer script. I will have to 
write it from scratch again so it will take a while.

Original comment by XhmikosR on 10 Feb 2011 at 1:29

[GoogleCodeExporter]

You can use mine if you like

Original comment by samuelma...@gmail.com on 10 Feb 2011 at 2:51

[GoogleCodeExporter]

I finally got to spend some time with the Inno Setup installer. I've made 
almost all the things I wanted, except for adding a task for the associations 
and for making Notepad2 the default notepad for windows. Anyway, all the 
changes are in the "inno" branch in the svn.

Attached are the installers for the 3 different compiler builds. Note that the 
WDK build should work on Win2K now again.

Please test it and let me know.

Original comment by XhmikosR on 27 Oct 2011 at 1:45

Attachments:

• Notepad2-mod.4.2.25.613_ICL12.exe
• Notepad2-mod.4.2.25.613_VS2010.exe
• Notepad2-mod.4.2.25.613_WDK.exe

[GoogleCodeExporter]

I forgot to add the despite of the fact that there isn't any task for the 
default windows notepad, the installer behaves like the old one and makes 
Notepad2 the default notepad. I'll try to make it optional in the future, but 
for now I want to make sure that everything works smooth (i.e. the transition 
to the new installer etc).

Original comment by XhmikosR on 27 Oct 2011 at 1:48

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

o.O

You could've just gotten mine 8 months ago!

Original comment by samuelma...@gmail.com on 27 Oct 2011 at 5:26

[GoogleCodeExporter]

Well I doubt you have the same code and we'll never know. But that's not what I 
was asking about.

Original comment by XhmikosR on 27 Oct 2011 at 6:11

[GoogleCodeExporter]

Installing the VS2010 version on XP SP3 x86 results in the following error:
Runtime Error (at -1:0)
Cannot Import dll:C:\DOCUME~1\MAIN_U~1\LOCALS~1\Temp\is-20PSQ.tmp\psvince.dll.

Original comment by mr.jacob...@gmail.com on 27 Oct 2011 at 10:19

[GoogleCodeExporter]

Thanks for the report. It must be something with the new psvince.dll which is 
modified to detect 64bit processes. The installer works for me on Vista and 
Windows 7 (I don't have access to older systems).

I'm not sure there are a lot I can do regarding that matter. If Notepad2 had a 
mutex I could use that, but unfortunately it doesn't.

A possible workaround would be to use the old IsModuleLoaded function on 32bit 
windows and the new one on 64bit Windows. But I'm not sure how to do it at 
runtime (and if it's going to work).

Original comment by XhmikosR on 28 Oct 2011 at 10:57

[GoogleCodeExporter]

Alternatively, I just succeeded checking for Notepad2 by checking for the 
window class name. It should work in any case regardless of the operating 
system.

What I'd really like though is to add and use a mutex. If anyone can provide a 
working patch to add a mutex, please do so.

Please try the attached installer and let me know.

Original comment by XhmikosR on 28 Oct 2011 at 11:11

Attachments:

• Notepad2-mod.4.2.25.613_VS2010.exe

[GoogleCodeExporter]

The new installer in comment 17 now works on my XP SP3 x86 PC.

Original comment by mr.jacob...@gmail.com on 28 Oct 2011 at 2:27

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

@mr.jacob...: can you try this attached installer? It should work on XP too 
using the modified psvince.dll.

Original comment by XhmikosR on 29 Oct 2011 at 6:56

Attachments:

• Notepad2-mod.4.2.25.618_VS2010.exe

[GoogleCodeExporter]

Exact same error as the VS2010 installer in comment 10. No go.

Original comment by mr.jacob...@gmail.com on 29 Oct 2011 at 9:51

[GoogleCodeExporter]

@mr.jacob...: This is my last try with psvince for now. Please let me know if 
you still get the same error. Otherwise I'll simply got with the window's class 
name approach and hope someone will provide a proper patch with a mutex.

Original comment by XhmikosR on 30 Oct 2011 at 1:09

Attachments:

• Notepad2-mod.4.2.25.620_VS2010.exe

[GoogleCodeExporter]

Good to go, version Notepad2-mod.4.2.25.620_VS2010.exe installs and uninstalls 
OK on my system.

Original comment by mr.jacob...@gmail.com on 30 Oct 2011 at 9:13

[GoogleCodeExporter]

All right, final installers for testing.

Let me know if there are any issues.

Original comment by XhmikosR on 31 Oct 2011 at 11:16

Attachments:

• Notepad2-mod.4.2.25.623_ICL12.exe
• Notepad2-mod.4.2.25.623_VS2010.exe
• Notepad2-mod.4.2.25.623_WDK.exe

[GoogleCodeExporter]

XP SP3 x86, old AMD cpu:
ICL12 failed, I guess because cpu don't support SSE2
VS2010 success
WDK success

Original comment by mr.jacob...@gmail.com on 31 Oct 2011 at 1:49

[GoogleCodeExporter]

But it showed you the error message, right? If yes then the installer should be 
ready to merge to trunk.

Original comment by XhmikosR on 31 Oct 2011 at 2:04

[GoogleCodeExporter]

Yes, the installer with the ICL build gave me an error and didn't install, that 
is correct.

Original comment by mr.jacob...@gmail.com on 31 Oct 2011 at 2:40

[GoogleCodeExporter]

Committed a few revisions ago.

Original comment by XhmikosR on 13 Dec 2011 at 2:31

• Changed state: Fixed