C# "Global Class" highlighting

google-code-export / notepad2-mod

Automatically exported from code.google.com/p/notepad2-mod

Other

2 stars 1 forks source link

C# "Global Class" highlighting #71

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Hello once again,

I made the "Global Class" highlighting available for C# and filled it with 
classes from the .NET Framework 3.5 Common Namespaces and Types Poster 
(http://www.microsoft.com/download/en/details.aspx?id=19341).
I have not changed the default color so it doesn't break with current 
highlighting.

Patch attached. Let me know what you think about it.

Best regards

Original issue reported on code.google.com by Volk...@gmail.com on 25 Jan 2012 at 1:28

Attachments:

CS_GlobalClass.patch

GoogleCodeExporter commented 9 years ago

Updated patch. System is not a class...

Original comment by Volk...@gmail.com on 25 Jan 2012 at 1:36

Attachments:

CS_GlobalClass.patch

GoogleCodeExporter commented 9 years ago

No idea what that is, so I for one don't need it. Also the patch isn't correct.

Original comment by XhmikosR on 25 Jan 2012 at 1:40

Added labels: Type-Enhancement, Priority-Low
Removed labels: Type-Defect, Priority-Medium

GoogleCodeExporter commented 9 years ago

What's wrong with the patch?

Original comment by Volk...@gmail.com on 25 Jan 2012 at 1:46

GoogleCodeExporter commented 9 years ago

1) The keywords don't have to be mixed case
3) I'm not sure about the keywords array and your changes there
3) You certainly don't have to touch Notepad2.rc
4) You should use the next available ID which atm is 63338 and not a random 
number you chose

At any case, I'm not interested about this, unless there is a fully working 
patch which I might commit or not.

Original comment by XhmikosR on 25 Jan 2012 at 1:50

GoogleCodeExporter commented 9 years ago

1) These aren't keywords but class names. They are case-sensitive.
2) There's nothing I can do about that... Therefore I linked the poster.
3) Fixed.
4) Fixed.

Two images are attached to show the difference (with and without highlighting).

Original comment by Volk...@gmail.com on 25 Jan 2012 at 2:18

Attachments:

GoogleCodeExporter commented 9 years ago

Either way, I won't commit it since I don't need it.
BTW, I see no point in that patch if there is no highlighting by default.

Maybe I'll commit it in the future though.

Original comment by XhmikosR on 25 Jan 2012 at 2:32

GoogleCodeExporter commented 9 years ago

If you want this committed, please provide a fully working patch with the above 
feature enabled and I will commit it.

Original comment by XhmikosR on 24 Jul 2012 at 6:30

Added labels: Priority-Medium
Removed labels: Priority-Low

GoogleCodeExporter commented 9 years ago

Here is my current patch for C#. It also containes the new C# 5 keywords async 
and await (Reference: 
http://msdn.microsoft.com/en-us/library/the35c6y(v=vs.110) ).
Global Classes have the highlighting seen on the screenshot by default.

Original comment by Volk...@gmail.com on 5 Aug 2012 at 6:54

Attachments:

CS_Highlighting_r756.patch

GoogleCodeExporter commented 9 years ago

Thanks, committed in r758. Feel free to post here for any further changes.

Original comment by XhmikosR on 16 Aug 2012 at 7:00

Changed state: Fixed