google-code-export / nyromodal

Automatically exported from code.google.com/p/nyromodal
1 stars 1 forks source link

Feature Request: Add jQuery UI theme support #349

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
jQuery UI is pretty great and I've been using it extensively on our
project. http://www.jqueryui.com/

But when using NyroModal it's a bit of a visual mismatch.  I'd love it if
NyroModal could use the proper classes to add jQuery UI themeing support.

I've attached a version of NyroModal that I've hacked together to get some
basics working, but it's far from perfect.

If the dev for this project could take a look here and see if it would be
possible to add as an official feature, that would be amazing.

Original issue reported on code.google.com by chris.m....@gmail.com on 7 Oct 2009 at 3:29

Attachments:

GoogleCodeExporter commented 9 years ago
Wooh, that's a cool idea!
I quickly reviewed the code you sent.
Basically, what you did:
- increase the height by 35px. Why?
- Add some CSS class in some divs to use the jQuery UI styles.

Anything else?

And what's not working with your version (I didn't test it).

Could you share a page where we can see it in action?

Original comment by nyro...@gmail.com on 9 Oct 2009 at 7:18

GoogleCodeExporter commented 9 years ago
I had to add a 35px height because the title bar needs a bit more height when 
using
the jQueryUI stuff. It's not perfect, but it works in most cases.

Yeah, the great thing about jQuery UI is that all that is needed to use it is 
to add
a few classes to containers and include the jQueryUI CSS file(s)

Some content doesn't work quite well, and it's a bit quirky when resizing the
browser. I also just hacked it in there just to get it to work for our needs 
only. It
probably needs a more thorough look over than what I gave it.

Unfortunately, I don't have a publicly available page you can see for this. Just
download any theme in jQueryUI, and include it on the demo page you zip up with 
the
download to see it work.  That should work just fine (I hope).

I'd *LOVE* to see this properly implemented by the actual developer instead of 
hacked
in by me - if for no other reason than I'm tired of having to re-hack it in 
every
time you make an update to the real NyroModal, haha.

Original comment by chris.m....@gmail.com on 9 Oct 2009 at 7:49

GoogleCodeExporter commented 9 years ago
I'm the actual developer, and I'll take a look. I don't know exactly when I 
could do it.
I think it will be a new setting in nyroModal to enable the jQuery UI theming.

Thanks anyway for your work and suggestion!

Original comment by nyro...@gmail.com on 9 Oct 2009 at 7:54

GoogleCodeExporter commented 9 years ago
Hi Chris, 

I just used it today and it works fine.

Is it possible to have a caption on the modal titlebar ?

Thanks in advance,
Bruno

Original comment by alliance...@gmail.com on 1 Oct 2010 at 10:57