search

google-code-export / nyromodal

Automatically exported from code.google.com/p/nyromodal
1 stars 1 forks source link

jQuery bug ref #7180 highlights issue with nyroModal overwriting jQuery functions #553

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi guys, 

I discovered an issue when I revisited nyroModal for a recent project.  Upon 
doing some Googling, I found I wasn't the only one with the issue and a bug 
report has been filed with the jQuery guys (which they have duly closed as 
probably not their problem).

I had a quick look at the issue and posted a comment in their issue: 
http://bugs.jquery.com/ticket/7180#comment:7  Please can you review this 
comment in case I have made a mistake.

In summary, I said that I thought that line #341 of jquery.nyroModal-1.6.2.js 
should be changed from:

    callingSettings = $.extend(true, settings);

to:

    callingSettings = $.extend(true, {}, settings);

so as not to overwrite any functions of jQuery, itself.

Apologies if this is not the correct place for this, but I thought you should 
at least know.

Regards,

J.

Original issue reported on code.google.com by jimbobmc...@googlemail.com on 1 Dec 2010 at 6:28