search

google-code-export / objectify-appengine

Automatically exported from code.google.com/p/objectify-appengine
MIT License
1 stars 0 forks source link

Implement separation of lifecycle event handling from entity #39

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
As discussed in the following thread:

http://groups.google.com/group/objectify-appengine/browse_thread/thread/d3cde5bb
408f839

and proposed by Scott and Jeff, please implement an additional lifecycle event 
handling not within 
the entity class itself, but rather as an external EventListener.

The following reference shows the equivalent Hibernate design:

http://docs.jboss.org/hibernate/stable/entitymanager/reference/en/html/listeners
.html

Original issue reported on code.google.com by drasko.kokic on 26 May 2010 at 10:15

GoogleCodeExporter commented 9 years ago

Original comment by lhori...@gmail.com on 27 May 2010 at 1:25

GoogleCodeExporter commented 9 years ago

Original comment by lhori...@gmail.com on 30 Jun 2010 at 1:55

GoogleCodeExporter commented 9 years ago 
I gave the implementation a go, you can check out the patch (based on revision 
589) at http://codereview.appspot.com/2111044/.

See 
http://groups.google.com/group/objectify-appengine/browse_thread/thread/dfc19d98
07968c9a for the related discussion.

Original comment by thomas.v...@gmail.com on 10 Sep 2010 at 3:47

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Following from the feedback I got in the above mentioned discussion I made a 
new proposal patch:

http://codereview.appspot.com/2238044/

Original comment by thomas.v...@gmail.com on 21 Sep 2010 at 12:26

GoogleCodeExporter commented 9 years ago 
Did you see the msg I posted to the objectify mailing list?

I think that your patch is close, it just needs a few changes before it can be 
applied to trunk.  I can make the changes myself and apply, but I think we'd 
all rather have you involved in development!  If you're still working on the 
patch let us know, or if you'd rather I make the changes let us know.

Original comment by lhori...@gmail.com on 27 Sep 2010 at 6:01

GoogleCodeExporter commented 9 years ago 
I got the message but I'm away for the next 6 weeks and most likely wont be 
able to do work in that period. I would like to finish it after that, but if 
that's too late you could finish it yourself.

Thomas

Original comment by thomas.v...@gmail.com on 27 Sep 2010 at 9:37

GoogleCodeExporter commented 9 years ago 
No rush.  Unless a bunch of people start screaming for the feature on the 
mailing list, we can wait.

Original comment by lhori...@gmail.com on 27 Sep 2010 at 9:48

GoogleCodeExporter commented 9 years ago 
New and hopefully improved patch: http://codereview.appspot.com/3181042/ I'll 
explain the differences in the google group thread 
(http://groups.google.com/group/objectify-appengine/browse_thread/thread/dfc19d9
807968c9a)

Original comment by thomas.v...@gmail.com on 18 Nov 2010 at 4:00

GoogleCodeExporter commented 9 years ago 
While using the patch I ran into some bugs, please see the improved patch: 
http://codereview.appspot.com/3370041/

Original comment by thomas.v...@gmail.com on 1 Dec 2010 at 4:49

GoogleCodeExporter commented 9 years ago 
Issue 170 has been merged into this issue.

Original comment by lhori...@gmail.com on 14 Apr 2014 at 1:09

GoogleCodeExporter commented 9 years ago 
We can now mark this closed & resolved I guess.

Original comment by hus...@gmail.com on 11 Jan 2015 at 9:28

GoogleCodeExporter commented 9 years ago 
Not really - the request is to put listeners into a separate implementation 
class. Currently Objectify supports only @OnSave and @OnLoad on the pojo class.

Original comment by lhori...@gmail.com on 14 Jan 2015 at 2:19