google-code-export / openhab

Automatically exported from code.google.com/p/openhab
GNU General Public License v3.0
0 stars 0 forks source link

digitalSTROM binding doesn't work in 1.3.0 #446

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Download openhab-runtime-1.3.0.zip, openhab-addons-1.3.0.zip
2. Install openhab 1.3.0 as described here 
https://code.google.com/p/openhab/wiki/Setup
3. Copy digitalSTROM binding from openhab-addons-1.3.0.zip into installed 
openhab addons directory
4. Configure digitalSTROM as described here 
https://code.google.com/p/openhab/wiki/digitalSTROMBinding
5. Start openhab:
sh ./start.sh

What is the expected output? What do you see instead?
digitalSTROM binding works good in stable openhab 1.2.0

In openhab 1.3.0 release only scene items properly send commands to 
digitalSTROM.
Device calls don't work. 

... 
16:44:50.982 INFO  o.o.b.d.i.DigitalSTROMBinding[:1693]- SUCCESSFULLY got 
session-token
16:45:26.254 INFO  o.o.b.d.i.DigitalSTROMBinding[:411]- 
internalReceiveCommand() is called!
16:45:26.254 WARN  o.o.b.d.i.DigitalSTROMBinding[:859]- couldn't find 
digitalstrom device for Light_GF_Room_3_Desk_Lamp
...

Please use labels and text to provide additional information.

Fix is checked in 
http://code.google.com/r/fsqfsg-openhab-digitalstrom/source/detail?r=d2712a0617a
d97f2e1846fe99f3ffb3b9d3deab9
and should be available in 1.3.1 Bugfix Release

Use attached build until 1.3.1 will be released.

Thanks to Hans-Jörg Merk for testing

Original issue reported on code.google.com by fsq....@googlemail.com on 13 Sep 2013 at 12:11

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, fixed with changeset 
https://code.google.com/p/openhab/source/detail?r=47d815098e7996060b6989523ed460
1037a88628&name=1.3.1

Original comment by kai.openhab on 14 Sep 2013 at 8:46

GoogleCodeExporter commented 9 years ago
Hi,
Sorry Kay, but the fix Alex referred to, is not the correct one.
Please add the following fix and afterwards the one from Alex's post.

http://code.google.com/r/fsqfsg-openhab-digitalstrom/source/detail?r=55117e5215a
a527ed6d06eeca344befed4d5ec30

Thanks
Josh

Original comment by josh.m5968 on 17 Sep 2013 at 8:44

GoogleCodeExporter commented 9 years ago
Thanks Josh, I will look into this.

Original comment by kai.openhab on 18 Sep 2013 at 1:34

GoogleCodeExporter commented 9 years ago
I backed out the first fix (which was only changing JSONDeviceImpl), but the 
changeset 55117e5215aa527ed6d06eeca344befed4d5ec30 cannot be applied. There are 
many merge errors in digitalstrombinding.xml, DigitalSTROMBindingProvider.java, 
DigitalSTROMGenericBindingProvider.java, HttpTransport.java and 
DigitalSTROMBindingChangeListener.java

Could you provide a patch based on the latest 1.3.1 branch, please? If possible 
in the next few hours as we want to release 1.3.1 TODAY!

Original comment by kai.openhab on 18 Sep 2013 at 2:03

GoogleCodeExporter commented 9 years ago
Fixed with changeset 
https://code.google.com/p/openhab/source/detail?r=d6dbd82c86ca9289b45c85ee396243
174881eab4

Original comment by kai.openhab on 20 Sep 2013 at 7:10