Take the row selector that is used in the dashboard, and use it in the feedback tab as well.

[GoogleCodeExporter]

In the dashboard, you can hover over a row (which darkens) and then click 
anywhere on that row to open the corresponding exploration or feedback thread. 
It would be nice to also have similar functionality in the main feedback tab of 
the exploration editor.

This was noted by Jacob in: https://code.google.com/p/oppia/issues/detail?id=426

Original issue reported on code.google.com by s...@google.com on 1 Nov 2014 at 1:49

[GoogleCodeExporter]

Hi,
I am working on this issue and want to know the page in which i have to make 
changes.

Original comment by shalinir...@gmail.com on 8 Jan 2015 at 7:03

[GoogleCodeExporter]

The feedback tab of the editor, so 
core/templates/dev/head/editor/exploration_feedback.html

Original comment by jacobdav...@gmail.com on 8 Jan 2015 at 7:16

[GoogleCodeExporter]

Hey, i have made changes according to this issue, can i push the changes 
directly or i have to submit a patch, Please elaborate

Original comment by shalinir...@gmail.com on 10 Jan 2015 at 2:52

[GoogleCodeExporter]

Hi,

Thanks for contributing to Oppia!

Would you be able to create a clone of the repo following the instructions at 
the bottom of this page?

    https://code.google.com/p/oppia/source/checkout

Then, follow the development workflow here:

    https://code.google.com/p/oppia/wiki/DevelopmentWorkflow

i.e., checkout the 'develop' branch, make a new branch based off of it, make 
your changes to this branch, and push these changes to your clone. Once you've 
done that, please send a link to your commit for review.

If all looks good, I'd be happy to give you access to the main repository, and 
from then on you can contribute directly. The main reason I suggest doing it in 
a temporary clone first is so that you can familiarize yourself with the 
development workflow in a safe environment, without the risk of breaking things 
in the main repository. Would that be OK?

Original comment by s...@seanlip.org on 10 Jan 2015 at 3:04

[GoogleCodeExporter]

Sure, will comment the commit link soon. Thanks for the help

Original comment by shalinir...@gmail.com on 10 Jan 2015 at 3:20

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I have made changes, and this is link 
https://code.google.com/r/shaliniroy012-oppia/source/detail?r=e4aed138a48a7fa4f1
63c430c51d0505ecc12dfe&name=shalini-devel ,
now what i have to do for commit review.

Original comment by shalinir...@gmail.com on 11 Jan 2015 at 6:41

[GoogleCodeExporter]

Thanks, this looks great! I don't seem to have permissions to review on your 
clone, but the commit is small enough that I think commenting here would 
suffice.

One minor issue is that, in the CSS, I would suggest using 
.oppia-feedback-tab-row instead and putting these selectors near the bottom of 
the file (since the place you put them originally is meant for classes that 
replace the predefined Bootstrap classes). The reason for the .oppia- prefix is 
to distinguish these classes from vanilla Bootstrap ones, and the reason for 
using 'feedback-tab' instead of 'feedback' is to distinguish the feedback tab 
from the 'feedback' that is given to the learner when they enter a particular 
response.

Other than that, the commit looks great!

One major issue, however, is that this branch is done on top of 'master' rather 
than on top of 'develop'. In general, commits should be done based off of 
'develop', and the 'master' branch should never be touched at all. (This is 
because the former is our active development branch, and the latter corresponds 
to the live site and is updated when a release happens.) Please read this page 
carefully (note the warning at the top):

    https://code.google.com/p/oppia/wiki/DevelopmentWorkflow

as well as this one:

    https://www.atlassian.com/git/tutorials/comparing-workflows/feature-branch-workflow

to learn more about how this works, so that you are always developing based on 
the correct branch. The first of these pages also includes instructions on how 
to ask for a code review.

So... would you mind redoing this commit on your clone, but from the 'develop' 
branch this time? Then delete the current shalini-devel branch (this is just to 
get practice with handling branches). When you've done that, and are happy with 
the commit, please reply to this thread to request a review. If you could also 
sign the CLA in the meantime, I should then be able to add you as a committer 
to the main project:

    https://cla.developers.google.com/about/google-individual

Thanks, and don't hesitate to reply if you have any questions, or if any of 
this doesn't make sense!

Original comment by s...@seanlip.org on 11 Jan 2015 at 7:04

[GoogleCodeExporter]

I have made changes accordingly and push it but can't found "Request code 
review".
link:- 
https://code.google.com/r/shaliniroy012-oppia/source/detail?r=ee7c1ebc73b26569cb
be9464a7e6fca2c7ce9c13&name=shalini-devel
And I have already sign the CLA.

Original comment by shalinir...@gmail.com on 12 Jan 2015 at 7:12

[GoogleCodeExporter]

Thank you, Shalini! The commit looks great. I've added you as a committer to 
the main repo; would you mind repeating the commit in a branch on this repo?

After that, you should be able to click the "Request a review" link at the top 
(go to the Source tab, and it should be in the sub-navbar on the right of 
Clones).

Original comment by s...@google.com on 12 Jan 2015 at 4:46

[GoogleCodeExporter]

Original comment by s...@seanlip.org on 12 Jan 2015 at 4:48

[GoogleCodeExporter]

Original comment by shalinir...@gmail.com on 14 Jan 2015 at 6:29

• Changed state: Fixed