google-code-export / ords

Automatically exported from code.google.com/p/ords
1 stars 0 forks source link

SQL query box returns a success message whether query was successful or not #434

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to the SQL query box for a database of your choice.
2. Type some nonsense into the box, and click 'Run query'.
3. Observe that the message at the top of the screen says 'Success', even 
though lower down, you're told that ORDS was 'Unable to run query due to 
database error.'

What is the expected output? What do you see instead?
We really need some more helpful messages here: 'Success' is fine if the query 
actually was successful, but the system needs to distinguish those that work 
and those that don't.

Ideally, the message you get further down the screen should also reflect what's 
actually happening. Sometimes it may be a database error; sometimes it may 
simply be that the user has mistyped something.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by meriel.p...@gmail.com on 14 Jul 2014 at 10:12

GoogleCodeExporter commented 9 years ago
I've just discovered something really weird: if you turn on the langdebug mode, 
the messages suddenly get much more helpful.

To see this, type something that's definitely not a well-formed SQL query in 
the box, and click 'Run query'. ORDS will return the usual cheery 'Success' 
message. Now add &langdebug=true to the end of the URL. Instead of the 
'Success' message, ORDS now tells you that it was 'Unable to run query due to 
database error.', and also gives a second error message which is rather opaque, 
but which I think is indicating where and what the problem was.

Original comment by meriel.p...@gmail.com on 14 Jul 2014 at 10:38

GoogleCodeExporter commented 9 years ago

Original comment by meriel.p...@gmail.com on 14 Jul 2014 at 11:16

GoogleCodeExporter commented 9 years ago

Original comment by meriel.p...@gmail.com on 14 Jul 2014 at 11:16

GoogleCodeExporter commented 9 years ago
Even stranger, if your SQL query was ill-formed, you get the false 'success' 
message on screen after running it, but once you click to go to another screen 
in ORDS (e.g. go back to view, edit, query data) only then does it display the 
error message that should have accompanied the failed query immediately after 
it was run.

Original comment by jajwil...@gmail.com on 16 Jul 2014 at 9:42

GoogleCodeExporter commented 9 years ago
Assigning this to Mark given that Stoat is out of action this month

Original comment by jajwil...@gmail.com on 4 Aug 2014 at 9:29

GoogleCodeExporter commented 9 years ago
Upping to critical, because it's the thing that currently annoys me the most 
about ORDS

Original comment by jajwil...@gmail.com on 4 Aug 2014 at 9:33

GoogleCodeExporter commented 9 years ago
Setting milestone

Original comment by jajwil...@gmail.com on 4 Aug 2014 at 10:24

GoogleCodeExporter commented 9 years ago

Original comment by jajwil...@gmail.com on 4 Aug 2014 at 10:55

GoogleCodeExporter commented 9 years ago

Original comment by marxjohn...@gmail.com on 5 Aug 2014 at 1:51