search

google-code-export / ords

Automatically exported from code.google.com/p/ords
1 stars 0 forks source link

Jumping to a record number outside of the number of records in a database doesn't produce an error #552

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Go to the editing view for a table with, say, 3114 records
2. Try to jump to record number 4500
3. Notice that you end up on a screen with no records displayed which is 
described as page 'records #:1 to 100 of 3114' and 'Page: 1 of 32'

Alternatively...

1. enter a negative value in the 'Go to Record' box.
2. Watch as the ORDS crashes with the following error report..

HTTP Status 500 - An exception occurred processing JSP page /table.jsp at line 
129 126: fullTableData = PaginationUtils.viewTableData(dbUtils, session, 
currentTable, rowNum, tableColumnReferences, 127: navInfo, nextPage); 128: } 
129: fullTableData.setOriginalDbType(opd.getDatabaseType()); 130: %> 131: <!-- 
132: Check out Stacktrace:

type Exception report

message An exception occurred processing JSP page /table.jsp at line 129 126: 
fullTableData = PaginationUtils.viewTableData(dbUtils, session, currentTable, 
rowNum, tableColumnReferences, 127: navInfo, nextPage); 128: } 129: 
fullTableData.setOriginalDbType(opd.getDatabaseType()); 130: %> 131: <!-- 132: 
Check out Stacktrace:

description The server encountered an internal error (An exception occurred 
processing JSP page /table.jsp at line 129 126: fullTableData = 
PaginationUtils.viewTableData(dbUtils, session, currentTable, rowNum, 
tableColumnReferences, 127: navInfo, nextPage); 128: } 129: 
fullTableData.setOriginalDbType(opd.getDatabaseType()); 130: %> 131: <!-- 132: 
Check out Stacktrace:) that prevented it from fulfilling this request.

exception

org.apache.jasper.JasperException: An exception occurred processing JSP page 
/table.jsp at line 129

126:                 fullTableData = PaginationUtils.viewTableData(dbUtils, 
session, currentTable, rowNum, tableColumnReferences,
127:                     navInfo, nextPage);
128:             }
129:             fullTableData.setOriginalDbType(opd.getDatabaseType());
130:         %>
131:         <!--
132:         Check out

Stacktrace:
    org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:568)
    org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:470)
    org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
    uk.ac.ox.oucs.ords.servlets.filters.ParamFilter.doFilter(ParamFilter.java:24)
root cause

java.lang.NullPointerException
    org.apache.jsp.table_jsp._jspService(table_jsp.java:448)
    org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
    org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:432)
    org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
    uk.ac.ox.oucs.ords.servlets.filters.ParamFilter.doFilter(ParamFilter.java:24)
note The full stack trace of the root cause is available in the Apache 
Tomcat/7.0.28 logs.

What is the expected output? What do you see instead?
We shouldn't enable user to put a higher value in the 'go to record' box than 
the number of records in the table, nor a negative number

Please use labels and text to provide additional information.
Staging 1.0.5, under Chrome.

Because this is causing a genuine server error and not being properly caught, 
I'm going to call this one as a high priority rather than just a medium.

Original issue reported on code.google.com by jajwil...@gmail.com on 13 Oct 2014 at 2:48

GoogleCodeExporter commented 9 years ago

Original comment by jajwil...@gmail.com on 10 Dec 2014 at 4:34

GoogleCodeExporter commented 9 years ago

Original comment by jajwil...@gmail.com on 16 Feb 2015 at 10:30