Navigating between pages of query results crashes the system

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Enter a query that will give more than 100 results
2. Try to view the second page of results by clicking the 'next' button.
3. Watch the system crash

What is the expected output? What do you see instead?
I'd expect to see the next page of results, not this...

HTTP Status 500 - An exception occurred processing JSP page /tableData.jsp at 
line 105 102: <%= String.format(lang.getString("querydatafor"), cleanQuery, 
databaseType) %> 103: </h2> 104: 105: <% if 
(Integer.parseInt(request.getParameter("vid")) == 0) { %> 106: <form 
action="TableViewServlet" method="post"> 107: <button class="button" 
type="submit" name="saveView"><%= lang.getString("saveview") %></button> 108: 
<button class="button" type="submit" name="requestType" value="exportView"><%= 
lang.getString("exportview") %></button> Stacktrace:

type Exception report

message An exception occurred processing JSP page /tableData.jsp at line 105 
102: <%= String.format(lang.getString("querydatafor"), cleanQuery, 
databaseType) %> 103: </h2> 104: 105: <% if 
(Integer.parseInt(request.getParameter("vid")) == 0) { %> 106: <form 
action="TableViewServlet" method="post"> 107: <button class="button" 
type="submit" name="saveView"><%= lang.getString("saveview") %></button> 108: 
<button class="button" type="submit" name="requestType" value="exportView"><%= 
lang.getString("exportview") %></button> Stacktrace:

description The server encountered an internal error (An exception occurred 
processing JSP page /tableData.jsp at line 105 102: <%= 
String.format(lang.getString("querydatafor"), cleanQuery, databaseType) %> 103: 
</h2> 104: 105: <% if (Integer.parseInt(request.getParameter("vid")) == 0) { %> 
106: <form action="TableViewServlet" method="post"> 107: <button class="button" 
type="submit" name="saveView"><%= lang.getString("saveview") %></button> 108: 
<button class="button" type="submit" name="requestType" value="exportView"><%= 
lang.getString("exportview") %></button> Stacktrace:) that prevented it from 
fulfilling this request.

exception

org.apache.jasper.JasperException: An exception occurred processing JSP page 
/tableData.jsp at line 105

102:         <%= String.format(lang.getString("querydatafor"), cleanQuery, 
databaseType) %>
103:     </h2>
104: 
105:     <% if (Integer.parseInt(request.getParameter("vid")) == 0) { %>
106:     <form action="TableViewServlet" method="post">
107:         <button class="button" type="submit" name="saveView"><%= 
lang.getString("saveview") %></button>
108:         <button class="button" type="submit" name="requestType" 
value="exportView"><%= lang.getString("exportview") %></button>

Stacktrace:
    org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:568)
    org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:470)
    org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
root cause

java.lang.NumberFormatException: null
    java.lang.Integer.parseInt(Integer.java:454)
    java.lang.Integer.parseInt(Integer.java:527)
    org.apache.jsp.queryBuilder_jsp._jspService(queryBuilder_jsp.java:919)
    org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
    org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:432)
    org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
note The full stack trace of the root cause is available in the Apache 
Tomcat/7.0.28 logs.

Apache Tomcat/7.0.28

Please use labels and text to provide additional information.

Original issue reported on code.google.com by jajwil...@gmail.com on 11 Dec 2014 at 1:50

[GoogleCodeExporter]

n.b. Furthermore, if you try to navigate the a different page of results, the 
whole page reloads, hiding the results below the querying interface, which is 
awkward from a usability perspective. Could we not show the original query in 
it's fully split out form, butt just show what it is in a single line, so that 
the results page is dominated by results, not the query interface?

Original comment by jajwil...@gmail.com on 11 Dec 2014 at 1:52

[GoogleCodeExporter]

Original comment by jajwil...@gmail.com on 11 Dec 2014 at 1:53

• Added labels: Milestone-1.0.7

[GoogleCodeExporter]

I've just had a bash at simply making the "next" and "previous" buttons work 
with the page as-is but it's tricker than I thought. I suspect it will actually 
by easier to do what you suggest and have it show the results on a seperate 
page.  This does mean that users wont have the editable query form on the same 
page as the results, but then I can't think of another DBMS that tries to do 
this (for reasons which are becoming apparent).

Original comment by marxjohn...@gmail.com on 15 Dec 2014 at 3:42

[GoogleCodeExporter]

I've just committed a fix which separates out the query results into a new 
page, which should solve this problem as well as making the interface a bit 
cleaner.

Original comment by marxjohn...@gmail.com on 16 Dec 2014 at 11:48

[GoogleCodeExporter]

Original comment by marxjohn...@gmail.com on 16 Dec 2014 at 2:16

• Changed state: Fixed