google-code-export / ords

Automatically exported from code.google.com/p/ords
1 stars 0 forks source link

Query interface breaks if user enters the terminating semicolon #611

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a database and access the SQL query interface
2. Enter a query, terminated with a semicolon
3. Run the query

What is the expected output? 
The query results should be displayed

What do you see instead?
ORDS reports a syntax error as it tries to add a LIMIT clause to allow for 
pagination, but does so after the semicolon.

The interface should be fixed to strip the semicolon, and the server-side code 
altered to cope with having the semicolon entered.

Original issue reported on code.google.com by marxjohn...@gmail.com on 4 Feb 2015 at 9:47

GoogleCodeExporter commented 9 years ago
This is now fixed.  Semicolons are stripped from the end of queries pasted by 
the user, from the end of the query inputs when they lose focus, and from the 
end of queries when they are processed in tableData.jsp.  This belt-and-braces 
approach should prevent the problem.

Original comment by marxjohn...@gmail.com on 4 Feb 2015 at 10:20