google-code-export / oregoncore

Automatically exported from code.google.com/p/oregoncore
GNU General Public License v2.0
1 stars 0 forks source link

Spirit of Redemption #367

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The spell works fine however, when in Spirit of Redemption you can still take 
damage and die again so to speak. You're not supposed to be able to be 
attackable or take damage at all.

Original issue reported on code.google.com by henry...@gmail.com on 2 Jan 2011 at 11:54

GoogleCodeExporter commented 9 years ago
Yeah, confirmed

Original comment by wow_f...@hotmail.com on 2 Jan 2011 at 12:48

GoogleCodeExporter commented 9 years ago

Original comment by stfxm...@gmail.com on 2 Jan 2011 at 9:03

GoogleCodeExporter commented 9 years ago
What is we use SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE) on the 
priest when Spirit of Redemption is triggered?

Original comment by kapp.arno on 27 Jan 2011 at 5:48

GoogleCodeExporter commented 9 years ago
SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE) is bad move ;] It will 
chain trigger pvp off on BGs/arenas and so on

Original comment by LukaasM on 11 Feb 2011 at 2:06

GoogleCodeExporter commented 9 years ago
Well, It doesn't seem to work either. (Or I didn't manage to get it working).
Any idea ?

Original comment by kapp.arno on 11 Feb 2011 at 9:32

GoogleCodeExporter commented 9 years ago
In retail, the player dies then receives spirit form. When this happens they 
can be targeted just not attacked rendering the spirit un attackable. If you 
add the flag upon death then remove it after the spirit is removed it should be 
proper.

EX:

@@ -5507,11 +5507,13 @@
                 m_target->SetStandState(UNIT_STAND_STATE_STAND);
         }

+       m_target->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE);
         m_target->SetHealth(1);
     }
     // die at aura end
     else
         m_target->setDeathState(JUST_DIED);
+        m_target->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE);
 }

 void Aura::CleanupTriggeredSpells()

Original comment by colbyjam...@gmail.com on 23 Apr 2011 at 9:16

GoogleCodeExporter commented 9 years ago
This issue has been fixed. Thank you!

Original comment by colbyjam...@gmail.com on 24 Apr 2011 at 1:54