search

google-code-export / p-g-qvm

Automatically exported from code.google.com/p/p-g-qvm
Other
1 stars 0 forks source link

buffer overflow in G_SanitiseName #111

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Attached patch fixes a possible buffer overflow in G_SanitiseName().

The fix only allows MAX_NAME_LENGTH chars to be written to the output
buffer. Some places pass a string that can be longer than this for the
input, which is wrong but it is easier to fix here.

Credit goes to Amanieu for finding this bug.

Original issue reported on code.google.com by Rez...@gmail.com on 7 Jun 2008 at 10:28

Attachments:

GoogleCodeExporter commented 9 years ago 
This bug is present on all QVMs(including the head SVN). Might want to start 
patching and fast.

Original comment by cheahjun...@gmail.com on 7 Jun 2008 at 12:52

GoogleCodeExporter commented 9 years ago 
The only servers it isn't present on are the vanilla 1.1 server actually

Original comment by amanieu on 7 Jun 2008 at 1:24

GoogleCodeExporter commented 9 years ago 
Fixed.
Released as of 1.6
Revision 64

Original comment by Paradox460 on 7 Jun 2008 at 5:09