!rotation - determine which map slot the server is at

[GoogleCodeExporter]

I've coded !rotation for TremWars QVM and thought it might be useful for others.

It allows for the following:
  * Identify missing maps that have entries in the map rotation - they show up as red in 
!rotation
  * View which maps are in rotation
  * View which slot in rotation the server is up to

This will allows new players to easily become familiar with the servers map 
rotation - and allow 
players to see which map is next even after custom-voted maps.

I'm not sure how it will react with the "random map" slot, or how it will react 
to large rotations 
- but it should be easily integrated.

Note: This patch wasn't intended for P-G-QVM, primarily the !help entry will 
have to be 
manually ported.

Keep up the good work, P-G.

Original issue reported on code.google.com by cri...@gmail.com on 11 Jul 2008 at 2:52

Attachments:

• rotation.patch

[GoogleCodeExporter]

Ow, I wanted to make a perfect issue entry, and forgot to choose an appropriate 
issue type. :<
Could someone please fix it?

Original comment by cri...@gmail.com on 11 Jul 2008 at 3:12

[GoogleCodeExporter]

MMM, could replace our stupid info-maprotation.txt

If rezyn or google wants to check this out and make sure it would work with all 
the 
extra stuff, this would be great.

Original comment by Paradox460 on 11 Jul 2008 at 6:06

• Added labels: Type-Enhancement, Priority-High, Component-Admin, Component-Game, Component-Server
• Removed labels: Type-Defect, Priority-Medium

[GoogleCodeExporter]

Some comments:

* Where is G_MapExists() defined ?

* *RANDOM* slots will most likely throw a 'missing' warning - easily fixed.

* SST currently uses 2 map rotations and jumps between them with a goto, this 
will
not be handled and you will only get the rotation the server is currently on - 
but
not the other half of the complete map list. Minor really, but supporting this 
would
be a *lot* more code.

Original comment by Rez...@gmail.com on 11 Jul 2008 at 8:59

[GoogleCodeExporter]

Not really a lot more code, just an extra loop. :P

Original comment by amanieu on 11 Jul 2008 at 9:13

[GoogleCodeExporter]

G_MapExists() is defined in g_maprotation.c
grep is your friend :P

Additionally, Just modify the condition that only allows the active map 
rotation to output so that all map 
rotations output. I intended that the function only output the current map 
rotation because the other should 
be irrelevant unless it's active.

Original comment by cri...@gmail.com on 12 Jul 2008 at 2:39

[GoogleCodeExporter]

"the other should be irrelevant unless it's active" in most cases - but not in 
SST's.
(for clarity)

Original comment by cri...@gmail.com on 12 Jul 2008 at 2:41

[GoogleCodeExporter]

G_MapExists might be qvm specific addition, we don't have it, so would be nice 
to
have a patch that includes it :)

I did grep before complaining:

[johne@Fly trunk]$ grep -c "G_MapExists" src/game/g_maprotation.c
/storage/zips/rotation.patch 
src/game/g_maprotation.c:0
/storage/zips/rotation.patch:1

Original comment by Rez...@gmail.com on 12 Jul 2008 at 3:33

[GoogleCodeExporter]

G_MapExists was put into Lakitu7's qvm when he merged with the trem svn.

Original comment by amanieu on 12 Jul 2008 at 7:22

[GoogleCodeExporter]

Just so you know, my *RANDOM* thing added an existence check to right before it 
issues the "map <mapname>" 
command.  I doubt it will interfere, but I am just informing. (It was at least 
partly intended as a backup incase 
the *RANDOM* chooser failed for some reason...)

Original comment by doomagent13@yahoo.com on 16 Jul 2008 at 6:42

[GoogleCodeExporter]

No significant work done on. Can be re-opened if interest is still there.

Original comment by Paradox460 on 5 Sep 2008 at 11:19

• Changed state: WontFix