Local contrast crashes Photivo

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Open any .NEF (don't know if other formats affected)
2. See my settings file for all my options used, it works properly on 1:4 pipe
3. Try it to make a fullsize pipe jpeg; When photivo goes to "local contrast" 
it crashes
Output is: 
[...]
Progress : Dynamik
Progress : Korrigiere Belichtung
(../Sources/ptProcessor.cpp,  582): ExposureFactor      : 2,177011
Progress : Aufhellen
Progress : Texturkurve
(../Sources/ptProcessor.cpp,  902): Done conversion to LAB at 5449 ms.
(../Sources/ptProcessor.cpp,  908): Done texture curve at 10206 ms.
Progress : Texturkontrast 1
(../Sources/ptProcessor.cpp,  933): Done texture contrast 1 at 11295 ms.
Progress : Texturkontrast 2
(../Sources/ptProcessor.cpp,  954): Done texture contrast 2 at 12334 ms.
Progress : Lokaler Kontrast 1
Abgebrochen
(sry that it is German, but i think you know what it means. "Lokaler Kontrast" 
is "local contrast", "Abgebrochen" means "aborted").

What is the expected output? What do you see instead?
A fullsize jpeg of the picture would be expected, instead I see the message 
from photivo to go to the forum.

What version of the product are you using? On what operating system?
Photivo version 2011-09-18 (rev 57d1987141d5)+ (x64 version)
Language German
Archlinux x64 (Kernel 3.0) 
8 GB Ram
AMD Phenom(tm) II X4 965

Original issue reported on code.google.com by Evilandi...@gmail.com on 28 Sep 2011 at 9:38

Attachments:

• DSC_2896.pts

[GoogleCodeExporter]

Funny thing is that "local contrast" was not even activated. 

Original comment by Evilandi...@gmail.com on 28 Sep 2011 at 9:43

[GoogleCodeExporter]

It works when I first do a full pipe picture in photivo and then save it. So 
maybe this problem is just on the "save full pipe" option (right click on save) 
when you are not on 1:1 Pipe.

Original comment by Evilandi...@gmail.com on 28 Sep 2011 at 9:56

[GoogleCodeExporter]

We are both German ;-)

Brother John and I just tested and could both not reproduce with your settings. 
Local contrast in the terminal means local contrast stretch and this was active 
(bad naming, we should change it). So, could you please investigate a little 
more, cutting down the number of filters (to see if local contrast stretch 
reproducably fails on your system or if eg the texture contrasts before are 
essential for the problem.).

Two more questions, how many mega pixels do your images have? From which source 
did you install?

greets mike

Original comment by m...@mm-log.com on 29 Sep 2011 at 7:14

[GoogleCodeExporter]

Hi Mike,

I finally found out that "local contrast stretching I" causes the problem, I 
deactivated everything else.
Again my exact steps to reproduce:
- Open NEF in 1:4 Pipe
- deactivate all filters/etc
- activate "local contrast stretching I", I used 0.83/400/-0.30/1.00
- Right click on the save symbol (floppy symbol) and "save full size pipe"
- The desribed error occours.

If i first switch to 1:1 pipe it works (local contrast 1 takes ages, but it 
finishes after about 1 minute), I can save the jpeg afterwards. The problem 
seems to be in the "save full size pipe"-function .. maybe it does not wait 
long enough for "local contrast 1"?

My .NEFs are from Nikon D3100 and 18-105 lens. My image has 4608 x 3072 pixels, 
which means 14,1 to 14.2 mega pixels.

Source is photivo-hg 406-1 from AUR -> 
https://aur.archlinux.org/packages.php?ID=42421
It pulls the newest version from your mercurial server, so "406" has no meaning 
to the photivo version.

Tell me if I can provide some more information. I tried to get an "real" error 
message, but there seems to be no real debug option (or I did not find it) or 
error log.

Grüße,
Andreas ;)

Original comment by Evilandi...@gmail.com on 29 Sep 2011 at 7:44

[GoogleCodeExporter]

Ah I mixed up "local contrast 1" and "local contrast stretching I" again .. 
they are the same ;)

Original comment by Evilandi...@gmail.com on 29 Sep 2011 at 7:45

[GoogleCodeExporter]

If you still can't reproduce it, the last idea would be a .NEF from me for 
testing. 

I also checked that photivo is really the x64 version (I first thought I got 
the 32bit bug):
file /usr/bin/photivo
/usr/bin/photivo: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), 
dynamically linked (uses shared libs), for GNU/Linux 2.6.27, 
BuildID[sha1]=0x005384f08c99b4f5f62be1bc5d705d0584459393, stripped

Original comment by Evilandi...@gmail.com on 29 Sep 2011 at 7:48

[GoogleCodeExporter]

One last thing: 

Could you save the settings before generating the jpeg? It is a bit annoying 
when photivo crashes, because all your settings are gone and there is no .pts 
file.

Original comment by Evilandi...@gmail.com on 29 Sep 2011 at 8:00

[GoogleCodeExporter]

Could you reproduce it?

Original comment by Evilandi...@gmail.com on 6 Oct 2011 at 6:07

[GoogleCodeExporter]

Currently backup settings of the last working configuration are saved to your 
photivo settings directory, usually home/.photivo.

I tried to reproduce, but it works on my system... You could try with a 
different raw, or you could send one of your raws, or you could try a newer 
build (or build it yourself) maybe there was something wrong in the package... 
Sorry, no better news.

greets mike

Original comment by m...@mm-log.com on 6 Oct 2011 at 7:26

[GoogleCodeExporter]

Hi Mike,

I added you a .NEF which produces the error on my machine. (Most Tags in .NEF 
are deleted, but this does not matter as it also occours on original NEFs)
Again my exact steps to reproduce:
- Open NEF in 1:4 Pipe in photivo
- deactivate all filters/etc
- activate "local contrast stretching I", I used 0.83/400/-0.30/1.00
- I activated manual apply, so "apply" the settings and wait until it made the 
changes in 1:4 pipe
- Right click on the save symbol (floppy symbol) and "save full size pipe"
- The desribed error occours.

Here all dependencies on Arch:
exiv2 0.22-1
libgexiv2 0.3.1-1
fftw 3.3-1
graphicsmagick  1.3.12-2
lcms2   2.2-1
lensfun 0.2.5-2
liblqr  0.4.1-2
qt  4.7.4-3
shared-mime-info    0.90-1
gcc 4.6.1-4

makepkg config:
CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector 
--param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2"
CXXFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector 
--param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2"
LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,--hash-style=gnu"
(don't know if it is overwritten by Makefile or something)

And as a attachment a totally black .NEF ;)

Original comment by Evilandi...@gmail.com on 9 Oct 2011 at 4:57

Attachments:

• DSC_3255.NEF

[GoogleCodeExporter]

Five additional comments:

- When photivo crashes like described the backup.pts in $HOME/.photivo does not 
contain any changes I made so far
- You can find the PKGBUILD here (to see if photivo is maybe builded wrong): 
https://aur.archlinux.org/packages/ph/photivo-hg/PKGBUILD
- Here is the Package in AUR: https://aur.archlinux.org/packages.php?ID=42421
- I rebuilded it today, same problem.
- These error occours with all my NEFs, not a special one

Original comment by Evilandi...@gmail.com on 9 Oct 2011 at 5:02

[GoogleCodeExporter]

It works on my system with your raw and workflow. Sorry, I have no clue.

greets mike

Original comment by m...@mm-log.com on 10 Oct 2011 at 7:00

[GoogleCodeExporter]

Arch has very new packages compared to others like debian - maybe this error 
will come up again sometime ;)

I don't know what I could do else, so I think I stop using photivo for now on 
and try it again sometime ;)

Original comment by Evilandi...@gmail.com on 10 Oct 2011 at 7:09

[GoogleCodeExporter]

Well, I use the sources, so my build is quite new ;-) 

All next steps I could think of would require more work, like building it from 
sources or get a development system and debug it (like I would do, if I could 
reproduce the problem here...)

greets mike

Original comment by m...@mm-log.com on 10 Oct 2011 at 7:17

[GoogleCodeExporter]

Which distro did you use? 

The PKGBUILD from AUR builds directly from your code.google.com source, but I 
meant the packages in your distro in my last comment, arch it very bleeding 
edge. Maybe there is the problem. 

I got another two ideas what I could try:
I've got two more machines: my notebook with Archlinux, and my NAS with Ubuntu 
on it, I will try the same thing on those.
I also could try to produce the error in a vm.

Original comment by Evilandi...@gmail.com on 10 Oct 2011 at 7:23

[GoogleCodeExporter]

I use Ubuntu, Brother John has a Fedora VM. That filter doesn't use external 
libraries if I remeber well, so they should not matter...

greets mike

Original comment by m...@mm-log.com on 10 Oct 2011 at 7:36

[GoogleCodeExporter]

The strange thing is that the filter works in 1:1 pipe and you can save jpegs, 
but when you do 1:4 and try to do a "full size jpeg" as described it does crash.

I will try on ubuntu soon and report back.

Original comment by Evilandi...@gmail.com on 10 Oct 2011 at 7:39

[GoogleCodeExporter]

Any news?

greets mike

Original comment by m...@mm-log.com on 4 Nov 2011 at 10:15

[GoogleCodeExporter]

Works on Ubuntu, used Dariusz Duma's PPA for testing.

Don't know what the problem is on arch.

Original comment by Evilandi...@gmail.com on 6 Nov 2011 at 12:34