google-code-export / photivo

Automatically exported from code.google.com/p/photivo
GNU General Public License v3.0
3 stars 0 forks source link

Black Image #67

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Compilation and Installation according to the on site instruction
2. Opening a .CR2 file from a Canon Powershot G12

What is the expected output? What do you see instead?
I expect to see the image in the editing window. I am able to see it in the 
file browser preview window. If opening bitmaps in the editor I am able to see 
them. But when i try to open the .CR2 file, the image preview just shows an all 
black frame instead of my picture.

What version of the product are you using? On what operating system?
Ubuntu 11.10, product as default branch as per 19 Feb 2012.

Please provide any additional information below.

Original issue reported on code.google.com by fredrik....@gmail.com on 19 Feb 2012 at 4:16

GoogleCodeExporter commented 9 years ago
Hi, 

could you share such an image with us.

greets mike

Original comment by m...@mm-log.com on 19 Feb 2012 at 5:47

GoogleCodeExporter commented 9 years ago
Sure, no problem.
Sincerely, Fredrik

Original comment by fredrik....@gmail.com on 19 Feb 2012 at 10:00

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks. Well, it might take a little while to solve this :-(

greets mike 

Original comment by m...@mm-log.com on 21 Feb 2012 at 8:13

GoogleCodeExporter commented 9 years ago
Let me know if there's anything I can Do. Im a dev too. Although I have not 
worked with imaging programs.. What's strange to Me is that the file viewer can 
show it but not the editor. I havnt read your source but maybe i should.. Any 
recommended parts?
/Fred

Original comment by fredrik....@gmail.com on 21 Feb 2012 at 9:11

GoogleCodeExporter commented 9 years ago
That's a very nice offer :-)

The viewer shows the builtin preview jpeg of the RAW file, and the editor tries 
to load the raw file and fails. The raw loading is done via dcraw, Photivo has 
parts of it copied. So, the idea is to check which decoding function in ptDcRaw 
is called and check it against current dcraw. So, I would follow the call 
(*this.*m_LoadRawFunction)(); in RunDcRaw_Phase1. Additional there is an 
identify function in ptDcRaw, that sets several flags for the current file. It 
may also be, that this is off.

greets mike

Original comment by m...@mm-log.com on 22 Feb 2012 at 5:06

GoogleCodeExporter commented 9 years ago
You might want to have a look to the dlRaw source code on this point.
It reads your image flawlessly.
Note that the structure is still largely the same as photivo, but 

- Identify() is now called IsRaw()
- RunDcRaw_Phase1() is now called Unpack()
- All non loader functions (color scaling, demosaicing, highlights ...) are 
removed.

Jos

Original comment by jos@de-laender.be on 27 Feb 2012 at 7:08

Attachments:

GoogleCodeExporter commented 9 years ago
Forgot to say : the loader function is lossless_jpeg_load_raw(); for this image.

Jos

Original comment by jos@de-laender.be on 27 Feb 2012 at 7:09