google-code-export / poly2tri

Automatically exported from code.google.com/p/poly2tri
Other
2 stars 0 forks source link

add automated tests to JavaScript version #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
There is no automated unit tests in the JavaScript version. 
Should write some, to ease futures fixes and changes. 

Original issue reported on code.google.com by remi.tur...@gmail.com on 17 Mar 2013 at 5:55

GoogleCodeExporter commented 9 years ago
here are proposed changes to add automated tests + improve interactive tests.
(this is from a server side clone : should you accept the changes, it would be 
easier for me if you pull them, rather than creating new changes in the parent 
repo, else my clone goes out of sync)

1) add some toString() in poly2tri.js  
https://code.google.com/r/remiturboult-poly2tri-js-2/source/detail?r=1284a31c540
0da2aa67df46e5d537b49a7846f96

2) improve interactive tests : index.html
https://code.google.com/r/remiturboult-poly2tri-js-2/source/detail?r=1f3ce7ae892
35c4d52dc194dc1be7af01422e921

3) add automated tests, using jasmine.js (a number of files in this change)
https://code.google.com/r/remiturboult-poly2tri-js-2/source/detail?r=a6c089a9955
336df12ac36a1e8e62ff4ba08b56b

Original comment by remi.tur...@gmail.com on 17 Mar 2013 at 6:06

GoogleCodeExporter commented 9 years ago
Ah. Sorry for being a bit of a mercurial noob :). 

Anytime you want me to pull and push your changes to the main repo let me know.
If you wanted I could probably give you control over the main javascript repo 
so you can push changes yourself.

Original comment by thahlen@gmail.com on 17 Mar 2013 at 10:20

GoogleCodeExporter commented 9 years ago
yes, I still plan to push some changes (including MeshClean fix).
So, I am ok to get access to the main javascript repo if you can.

Original comment by remi.tur...@gmail.com on 19 Mar 2013 at 8:51