Settings>Geotagging Toggle does nothing

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Go to settings.
2. Disable Geotagging
3. Create a Find.

What is the expected output? What do you see instead?
No gps location data should be saved with the find.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by stan.f...@gmail.com on 25 Oct 2011 at 5:46

[GoogleCodeExporter]

Yes, the code for this settings feature has not been implemented. Good little 
task!

Original comment by ram8...@gmail.com on 25 Oct 2011 at 1:57

[GoogleCodeExporter]

Original comment by ram8...@gmail.com on 25 Oct 2011 at 3:20

• Changed state: Started

[GoogleCodeExporter]

On create, the FindActivity looks for the geoTag preference. (The default if it 
can't be found is to enable geotagging.)

Geotag is checked before creating the location manager.
And if geotag is disabled, long and lat fields are made invisible in the find 
layout. 

One thing I realized is that there are two options here. GONE and INVISIBLE. 
Invisible makes the field invisible but keeps the field position in the layout. 
This keeps a blank space where the field use to be. GONE removes the field 
completely. This would be ideal. However, currently this would break out 
relative positioning layout. Since other fields might be position respective 
the the long/lat field. (Ex: 
android:layout_toLeftOf="@+id/latitudeValueTextView")

Geotag is checked throughout the activity to avoid null pointer exceptions. 

Original comment by stan.f...@gmail.com on 1 Nov 2011 at 7:33

Attachments:

• [Issue 245.patch](https://storage.googleapis.com/google-code-attachments/posit-mobile/issue-245/comment-3/Issue 245.patch)

[GoogleCodeExporter]

This change has been implemented. 

Original comment by ram8...@gmail.com on 25 Nov 2011 at 10:50

• Changed state: Fixed